New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-33714][SQL] Migrate ALTER VIEW ... SET/UNSET TBLPROPERTIES commands to use UnresolvedView to resolve the identifier #30676
Conversation
Kubernetes integration test starting |
Kubernetes integration test status failure |
Test build #132445 has finished for PR 30676 at commit
|
Kubernetes integration test starting |
Kubernetes integration test status failure |
Test build #132450 has finished for PR 30676 at commit
|
cc @cloud-fan, thanks in advance! |
Test build #132451 has finished for PR 30676 at commit
|
Kubernetes integration test starting |
Kubernetes integration test status success |
Test build #132462 has finished for PR 30676 at commit
|
retest this please |
Kubernetes integration test starting |
Kubernetes integration test status failure |
Test build #132503 has finished for PR 30676 at commit
|
retest this please |
Test build #132536 has finished for PR 30676 at commit
|
retest this please |
The GA shows that the failed tests are the well-known ones from the thrift-server module. I'm merging it to master, thanks! |
Kubernetes integration test starting |
Kubernetes integration test status success |
Test build #132542 has finished for PR 30676 at commit
|
What changes were proposed in this pull request?
This PR adds
allowTemp
flag toUnresolvedView
so thatAnalyzer
can check whether to resolve temp views or not.This PR also migrates
ALTER VIEW ... SET/UNSET TBLPROPERTIES
to useUnresolvedView
to resolve the table/view identifier. This allows consistent resolution rules (temp view first, etc.) to be applied for both v1/v2 commands. More info about the consistent resolution rule proposal can be found in JIRA or proposal doc.Why are the changes needed?
To use
UnresolvedView
for view resolution.One benefit is that the exception message is better for
ALTER VIEW ... SET/UNSET TBLPROPERTIES
. Before, if a temp view is passed, you will just getNoSuchTableException
withTable or view 'tmpView' not found in database 'default'
. But with this PR, you will get more description exception message:tmpView is a temp view. ALTER VIEW ... SET TBLPROPERTIES expects a permanent view
.Does this PR introduce any user-facing change?
The exception message changes as describe above.
How was this patch tested?
Updated existing tests.