Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-31960][YARN][DOCS][FOLLOW-UP] Document the behaviour change of Hadoop's classpath propagation in migration guide #30903

Closed
wants to merge 1 commit into from
Closed

[SPARK-31960][YARN][DOCS][FOLLOW-UP] Document the behaviour change of Hadoop's classpath propagation in migration guide #30903

wants to merge 1 commit into from

Conversation

HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR is a followup of #28788, and proposes to update migration guide.

Why are the changes needed?

To tell users about the behaviour change.

Does this PR introduce any user-facing change?

Yes, it updates migration guides for users.

How was this patch tested?

GitHub Actions' documentation build should test it.

@HyukjinKwon
Copy link
Member Author

cc @dbtsai, @viirya, @tgravescs, @dongjoon-hyun. could you take a look when you find some time?

dongjoon-hyun
dongjoon-hyun approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

viirya
viirya approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkQA
Copy link

SparkQA commented Dec 23, 2020

Test build #133281 has finished for PR 30903 at commit 1bc2b89.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

Let me just merge this in. The last commit was removing a space ...

@HyukjinKwon
Copy link
Member Author

Merged to master and branch-3.1.

HyukjinKwon added a commit that referenced this pull request Dec 23, 2020
@HyukjinKwon
[SPARK-31960][YARN][DOCS][FOLLOW-UP] Document the behaviour change of…
a0d51ec 
… Hadoop's classpath propagation in migration guide

### What changes were proposed in this pull request?

This PR is a followup of #28788, and proposes to update migration guide.

### Why are the changes needed?

To tell users about the behaviour change.

### Does this PR introduce _any_ user-facing change?

Yes, it updates migration guides for users.

### How was this patch tested?

GitHub Actions' documentation build should test it.

Closes #30903 from HyukjinKwon/SPARK-31960-followup.

Authored-by: HyukjinKwon <gurwls223@apache.org>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
(cherry picked from commit d98c216)
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
@SparkQA
Copy link

SparkQA commented Dec 23, 2020

Test build #133285 has finished for PR 30903 at commit aa49b43.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Dec 23, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37879/

@SparkQA
Copy link

SparkQA commented Dec 23, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37883/

@github-actions github-actions bot added the DOCS label Dec 23, 2020
@SparkQA
Copy link

SparkQA commented Dec 23, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37883/

@SparkQA
Copy link

SparkQA commented Dec 23, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37879/

@dbtsai
Copy link
Member

dbtsai commented Jan 6, 2021

Sorry for the late reply. Thank you @HyukjinKwon to help on this documentation.

@HyukjinKwon HyukjinKwon deleted the SPARK-31960-followup branch January 4, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viirya viirya viirya approved these changes

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees
No one assigned
Labels
DOCS
Projects
None yet
Milestone
No milestone
5 participants
@HyukjinKwon @SparkQA @dbtsai @viirya @dongjoon-hyun