New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-33908][CORE] Refactor SparkSubmitUtils.resolveMavenCoordinates() 's return parameter #30922
Conversation
Kubernetes integration test starting |
Kubernetes integration test status failure |
core/src/test/scala/org/apache/spark/deploy/SparkSubmitUtilsSuite.scala
Outdated
Show resolved
Hide resolved
core/src/test/scala/org/apache/spark/deploy/SparkSubmitUtilsSuite.scala
Outdated
Show resolved
Hide resolved
Looks fine otherwise if the tests pass. |
Kubernetes integration test starting |
Kubernetes integration test status success |
Test build #133378 has finished for PR 30922 at commit
|
Test build #133364 has finished for PR 30922 at commit
|
retest this please |
Kubernetes integration test starting |
Kubernetes integration test status success |
Test build #133384 has finished for PR 30922 at commit
|
retest this please |
Test build #133390 has finished for PR 30922 at commit
|
Gentle ping @maropu |
Merged to master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for this change @AngersZhuuuu ! Looks much cleaner this way.
@@ -1201,7 +1202,7 @@ private[spark] object SparkSubmitUtils { | |||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AngersZhuuuu FYI you missed updating the @return
Scaladoc tag here, as well as the description which explicitly mentions a comma-delimited list. Would you mind submitting a follow-on to update?
…ths/resolveMavenDependencies ### What changes were proposed in this pull request? Fix un-correct doc of last change #30922 (comment) ### Why are the changes needed? FIx doc ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Builds finished correctly. Closes #31016 from AngersZhuuuu/SPARK-33908-FOLLOW-UP. Authored-by: angerszhu <angers.zhu@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
What changes were proposed in this pull request?
Per discuss in #29966 (comment)
We'd better change
SparkSubmitUtils.resolveMavenCoordinates()
's return value asSeq[String]
Why are the changes needed?
refactor code
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existed UT