Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPARK-4222 [CORE] use readFully in FixedLengthBinaryRecordReader #3093

Closed
wants to merge 1 commit into from
Closed

SPARK-4222 [CORE] use readFully in FixedLengthBinaryRecordReader #3093

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/scala/org/apache/spark/input/FixedLengthBinaryRecordReader.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ private[spark] class FixedLengthBinaryRecordReader
if (currentPosition < splitEnd) {
// setup a buffer to store the record
val buffer = recordValue.getBytes
fileInputStream.read(buffer, 0, recordLength)
fileInputStream.readFully(buffer)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, but this also doesn't check how many bytes were actually read?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, but readFully will either block until the full number of bytes is available, or throw an error:
http://docs.oracle.com/javase/6/docs/api/java/io/DataInput.html#readFully(byte[])

// update our current position
currentPosition = currentPosition + recordLength
// return true
Expand Down