[SPARK-32685][SQL] When specify serde, default filed.delim is '\t' #30942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add UT Since in Hive |
|
FYI @maropu @cloud-fan |
cloud-fan
reviewed
Dec 28, 2020
| @@ -505,7 +505,12 @@ class SparkSqlAstBuilder extends AstBuilder { | |||
| } else { | |||
| None | |||
| } | |||
| (Seq.empty, Option(name), props.toSeq, recordHandler) | |||
| val finalProps = if (!props.contains("field.delim")) { | |||
| props.toSeq ++ Seq("field.delim" -> "\t") | |||
There was a problem hiding this comment.
what's the behavior now? which delimiter do we use by default before this PR?
There was a problem hiding this comment.
what's the behavior now? which delimiter do we use by default before this PR?
No default we use '\u0001'
cloud-fan
reviewed
Dec 28, 2020
| @@ -505,7 +505,12 @@ class SparkSqlAstBuilder extends AstBuilder { | |||
| } else { | |||
| None | |||
| } | |||
| (Seq.empty, Option(name), props.toSeq, recordHandler) | |||
| val finalProps = if (!props.contains("field.delim")) { | |||
There was a problem hiding this comment.
is this case sensitive?
Yes, case sensitive
|
Test build #133421 has finished for PR 30942 at commit
|
cloud-fan
approved these changes
Dec 28, 2020
|
The code has been modified to make it easier for it to add other possible default parameters in specified Hive serde mode. |
|
thanks, merging to master! |
|
@AngersZhuuuu Please update the migration guide |
Yea |
cloud-fan
pushed a commit
that referenced
this pull request
Jan 6, 2021
…ault filed.delim to '\t' when user specifies serde ### What changes were proposed in this pull request? Update migration guide according to #30942 (comment) ### Why are the changes needed? update migration guide. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Not need Closes #31051 from AngersZhuuuu/SPARK-32685-FOLLOW-UP. Authored-by: angerszhu <angers.zhu@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In hive script transform, when we use specified serde, the
filed.delimis '\t'And change to other serde and explain query plan,
filed.delimis same.In spark current code, the result is as below:
We should keep same as hive.
Notic:
the result's NULL value is different is another issue https://issues.apache.org/jira/browse/SPARK-32684
Why are the changes needed?
Keep same with hive serde
Does this PR introduce any user-facing change?
In script transform, is not specified,
field.delimkeep same with hive as\tHow was this patch tested?
UT added