[SPARK-33990][SQL][TESTS] Remove partition data by v2 ALTER TABLE .. DROP PARTITION
#31014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cloud-fan @HyukjinKwon Could you review this PR. |
cloud-fan
approved these changes
Jan 4, 2021
dongjoon-hyun
approved these changes
Jan 4, 2021
There was a problem hiding this comment.
+1, LGTM. Thank you, @MaxGekk and @cloud-fan .
Merged to master.
MaxGekk
added a commit
to MaxGekk/spark
that referenced
this pull request
Feb 1, 2021
… DROP PARTITION` Remove partition data by `ALTER TABLE .. DROP PARTITION` in V2 table catalog used in tests. This is a bug fix. Before the fix, `ALTER TABLE .. DROP PARTITION` does not remove the data belongs to the dropped partition. As a consequence of that, the `select` query returns removed data. No By running tests suites for v1 and v2 catalogs: ``` $ build/sbt -Phive-2.3 -Phive-thriftserver "test:testOnly *AlterTableDropPartitionSuite" ``` Closes apache#31014 from MaxGekk/fix-drop-partition-v2. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit fc3f226) Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove partition data by
ALTER TABLE .. DROP PARTITIONin V2 table catalog used in tests.Why are the changes needed?
This is a bug fix. Before the fix,
ALTER TABLE .. DROP PARTITIONdoes not remove the data belongs to the dropped partition. As a consequence of that, theselectquery returns removed data.Does this PR introduce any user-facing change?
No
How was this patch tested?
By running tests suites for v1 and v2 catalogs: