[SPARK-34207][SQL] Rename isTemporaryTable to isTempView in SessionCatalog
#31295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kubernetes integration test starting |
|
@dongjoon-hyun @cloud-fan Could you review this PR, please. |
|
Kubernetes integration test status success |
|
Test build #134376 has finished for PR 31295 at commit
|
dongjoon-hyun
approved these changes
Jan 22, 2021
There was a problem hiding this comment.
@MaxGekk . Given the size of patch, we need JIRA ID for this for trace-ability. Could you file one?
MaxGekk
changed the title
isTemporaryTable to isTempView in SessionCatalogisTemporaryTable to isTempView in SessionCatalog
|
@dongjoon-hyun I added an JIRA id to the PR title. |
|
Merged to master. |
skestle
pushed a commit
to skestle/spark
that referenced
this pull request
Feb 3, 2021
…ionCatalog` ### What changes were proposed in this pull request? Rename `SessionCatalog.isTemporaryTable()` to `SessionCatalog.isTempView()`. ### Why are the changes needed? To improve code maintenance. Currently, there are two methods that do the same but have different names: ```scala def isTempView(nameParts: Seq[String]): Boolean ``` and ```scala def isTemporaryTable(name: TableIdentifier): Boolean ``` ### Does this PR introduce _any_ user-facing change? Should not since `SessionCatalog` is not public API. ### How was this patch tested? By running the existing tests: ``` $ build/sbt -Phive-2.3 -Phive-thriftserver "test:testOnly *SessionCatalogSuite" ``` Closes apache#31295 from MaxGekk/replace-isTemporaryTable-by-isTempView. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Rename
SessionCatalog.isTemporaryTable()toSessionCatalog.isTempView().Why are the changes needed?
To improve code maintenance. Currently, there are two methods that do the same but have different names:
and
Does this PR introduce any user-facing change?
Should not since
SessionCatalogis not public API.How was this patch tested?
By running the existing tests: