Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-34218][INFRA][FOLLOWUP] Fix Scala 2.13 profile typo in publish-snapshot #31338

Closed
wants to merge 1 commit into from
Closed

[SPARK-34218][INFRA][FOLLOWUP] Fix Scala 2.13 profile typo in publish-snapshot #31338

wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

This is a follow-up of #31311 and fixes a typo in Scala 2.13 profile section in publish-snapshot command.

Why are the changes needed?

To fix snapshot publishing for Scala 2.13.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manual.

@HyukjinKwon
Copy link
Member

Merged to master.

@dongjoon-hyun
Copy link
Member Author

Could you review this, @HyukjinKwon ? I missed this typo in the previous PR.

@dongjoon-hyun
Copy link
Member Author

Thank you so much!

@dongjoon-hyun dongjoon-hyun deleted the SPARK-34218-2 branch January 26, 2021 06:12
skestle pushed a commit to skestle/spark that referenced this pull request Feb 3, 2021
…-snapshot

### What changes were proposed in this pull request?

This is a follow-up of apache#31311 and fixes a typo in Scala 2.13 profile section in `publish-snapshot` command.

### Why are the changes needed?

To fix snapshot publishing for Scala 2.13.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Manual.

Closes apache#31338 from dongjoon-hyun/SPARK-34218-2.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: HyukjinKwon <gurwls223@apache.org>
@yuranos
Copy link

yuranos commented Oct 25, 2021

@dongjoon-hyun , should the doc config var SCALA_BINARY_VERSION also be updated to 2.13?

SCALA_BINARY_VERSION: "2.12"

@dongjoon-hyun
Copy link
Member Author

No. Since Apache Spark's default Scala binary is still 2.12, 2.12 on documentation is correct.
We still publish all Spark document with Scala 2.12.

@yuranos
Copy link

yuranos commented Oct 25, 2021

Ok then. Makes sense because I saw you were changing versions in the docs as well, and it was hard to believe you missed that.
Having said that - the document can still be improved:

For the Scala API, Spark 3.2.0 uses Scala 2.12. You will need to use a compatible Scala version (2.12.x).

3.2 is the first version that supports both 2.12 and 2.13. It's important to mention in the docs.

@dongjoon-hyun
Copy link
Member Author

Ya, you are correct with that document part. We had better mention the availability of Scala 2.13.
Could you file a JIRA and PR for that, @yuranos ? Then, we can release it as a part of Apache Spark 3.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants