Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-34502][SQL] Remove unused parameters in join methods #31617

Closed
wants to merge 1 commit into from
Closed

[SPARK-34502][SQL] Remove unused parameters in join methods #31617

wants to merge 1 commit into from

Conversation

huaxingao
Copy link
Contributor

@huaxingao huaxingao commented Feb 23, 2021 •
edited by viirya

What changes were proposed in this pull request?

Remove unused parameters in CoalesceBucketsInJoin, UnsafeCartesianRDD and ShuffledHashJoinExec.

Why are the changes needed?

Clean up

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing tests

@github-actions github-actions bot added the SQL label Feb 23, 2021
@c21
Copy link
Contributor

c21 commented Feb 23, 2021

LGTM if tests are passed. My bad. I probably introduced those in files CoalesceBucketsInJoin and ShuffledHashJoinExec. Also checked CartesianProductExec and the change makes sense to me.

dongjoon-hyun
dongjoon-hyun reviewed Feb 23, 2021
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @huaxingao . BTW, this looks worth of having a JIRA issue. Could you file one?

@huaxingao huaxingao changed the title [MINOR][SQL] Remove unused parameters [SPARK-34502][SQL] Remove unused parameters Feb 23, 2021
@huaxingao
Copy link
Contributor Author

jira opened @dongjoon-hyun

@SparkQA
Copy link

SparkQA commented Feb 23, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39943/

@SparkQA
Copy link

SparkQA commented Feb 23, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39943/

@viirya viirya changed the title [SPARK-34502][SQL] Remove unused parameters [SPARK-34502][SQL] Remove unused parameters in join methods Feb 23, 2021
@viirya
Copy link
Member

viirya commented Feb 23, 2021

Thanks. Merging to master.

@viirya viirya closed this in 443139b Feb 23, 2021
@huaxingao
Copy link
Contributor Author

Thanks, everyone!

@huaxingao huaxingao deleted the join-minor branch February 23, 2021 20:39
@dongjoon-hyun
Copy link
Member

Thank you, @huaxingao and all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongjoon-hyun dongjoon-hyun dongjoon-hyun left review comments

@viirya viirya viirya approved these changes

@c21 c21 c21 approved these changes

@zhengruifeng zhengruifeng zhengruifeng approved these changes

Assignees
No one assigned
Labels
SQL
Projects
None yet
Milestone
No milestone
6 participants
@huaxingao @c21 @SparkQA @viirya @dongjoon-hyun @zhengruifeng