[SPARK-34760][EXAMPLES] Replace favorite_color with age in JavaSQLDataSourceExample

[zengruios]

What changes were proposed in this pull request?

In JavaSparkSQLExample when excecute 'peopleDF.write().partitionBy("favorite_color").bucketBy(42,"name").saveAsTable("people_partitioned_bucketed");'
throws Exception: 'Exception in thread "main" org.apache.spark.sql.AnalysisException: partition column favorite_color is not defined in table people_partitioned_bucketed, defined table columns are: age, name;'
Change the column favorite_color to age.

Why are the changes needed?

Run JavaSparkSQLExample successfully.

Does this PR introduce any user-facing change?

NO

How was this patch tested?

test in JavaSparkSQLExample .

[maropu]

ok to test

[maropu]

Looks fine.

[AmplabJenkins]

Can one of the admins verify this patch?

[dongjoon-hyun]

Thank you for the fix, @zengruios .

However, this PR introduces inconsistency from Scala/Python examples.

Please see Scala/Python example.

    # $example on:write_partition_and_bucket$
    df = spark.read.parquet("examples/src/main/resources/users.parquet")
    (df
        .write
        .partitionBy("favorite_color")
        .bucketBy(42, "name")
        .saveAsTable("people_partitioned_bucketed"))
    # $example off:write_partition_and_bucket$

    # $example on:write_partition_and_bucket$
    df = spark.read.parquet("examples/src/main/resources/users.parquet")
    (df
        .write
        .partitionBy("favorite_color")
        .bucketBy(42, "name")
        .saveAsTable("people_partitioned_bucketed"))
    # $example off:write_partition_and_bucket$

I guess we need to replace peopleDF with usersDF instead at line 207.

[zengruios]

@dongjoon-hyun, thanks for your suggestion, maybe the table's name should be changed to user_partitioned_bucketed, I will try to fix it like this.

[maropu]

Could you merge the #31852 fix into this PR? These issues are similar and minor, so merging them looks okay.

[zengruios]

@maropu, OK，I will merge them.

[maropu]

Thank you, @zengruios

[zengruios]

@maropu, @dongjoon-hyun, I have update it, can you review it again, thanks!

[HyukjinKwon]

@yaooqinn maybe can you try merging this as a brand new committer :-)?

[yaooqinn]

thanks, @HyukjinKwon. I will merge this to master only, is it Okay?

[HyukjinKwon]

Improvements are not backported in general but looks like this is a bug fix in the example (reading from JIRA) which is usually backported. The JIRA states the affected versions are 3.0.1 and 3.1.1 so I would merge this to branch-3.1 and branch-3.0.

[yaooqinn]

Yea, LGTM~

[yaooqinn]

My network is not in good condition at the moment. It took years to fetch and push this PR to master :(.. Now, it's fighting for branch-3.1

[yaooqinn]

@zengruios Thanks for your first contribution to Apache Spark.

I have added you as a contributor at the JIRA side, and SPARK-34760 has been assigned to you.

Thanks for the review, @dongjoon-hyun @maropu @HyukjinKwon

Merged to master/3.1/3.0.

[HyukjinKwon]

👏

[dongjoon-hyun]

Congratulation, @zengruios and @yaooqinn .

[maropu]

late lgtm 👏