[SPARK-34770][SQL] InMemoryCatalog.tableExists should not fail if database doesn't exist #31860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
commented
Mar 17, 2021
| @@ -704,6 +704,9 @@ abstract class SessionCatalogSuite extends AnalysisTest with Eventually { | |||
| catalog.createTempView("tbl3", tempTable, overrideIfExists = false) | |||
| // tableExists should not check temp view. | |||
| assert(!catalog.tableExists(TableIdentifier("tbl3"))) | |||
|
|
|||
| // Id database doesn't exist, return false instead of failing. | |||
| assert(!catalog.tableExists(TableIdentifier("tbl1", Some("non-exist")))) | |||
There was a problem hiding this comment.
Before this PR, this test passes in HiveExternalSessionCatalogSuite, but fails in InMemorySessionCatalogSuite
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
dongjoon-hyun
approved these changes
Mar 17, 2021
maropu
approved these changes
Mar 17, 2021
|
The scala 2.13 failure is unrelated, I'm merging it to master/3.1, thanks for the review! |
cloud-fan
added a commit
that referenced
this pull request
Mar 17, 2021
…abase doesn't exist This PR updates `InMemoryCatalog.tableExists` to return false if database doesn't exist, instead of failing. The new behavior is consistent with `HiveExternalCatalog` which is used in production, so this bug mostly only affects tests. bug fix no a new test Closes #31860 from cloud-fan/catalog. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 1a4971d) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
flyrain
pushed a commit
to flyrain/spark
that referenced
this pull request
Sep 21, 2021
…abase doesn't exist This PR updates `InMemoryCatalog.tableExists` to return false if database doesn't exist, instead of failing. The new behavior is consistent with `HiveExternalCatalog` which is used in production, so this bug mostly only affects tests. bug fix no a new test Closes apache#31860 from cloud-fan/catalog. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 1a4971d) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
fishcus
pushed a commit
to fishcus/spark
that referenced
this pull request
Jan 12, 2022
…abase doesn't exist This PR updates `InMemoryCatalog.tableExists` to return false if database doesn't exist, instead of failing. The new behavior is consistent with `HiveExternalCatalog` which is used in production, so this bug mostly only affects tests. bug fix no a new test Closes apache#31860 from cloud-fan/catalog. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 1a4971d) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates
InMemoryCatalog.tableExiststo return false if database doesn't exist, instead of failing. The new behavior is consistent withHiveExternalCatalogwhich is used in production, so this bug mostly only affects tests.Why are the changes needed?
bug fix
Does this PR introduce any user-facing change?
no
How was this patch tested?
a new test