[SPARK-34881][SQL][FOLLOWUP] Implement toString() and sql() methods for TRY_CAST #32098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
cloud-fan
reviewed
Apr 8, 2021
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/TryCast.scala
Outdated
Show resolved
Hide resolved
yaooqinn
approved these changes
Apr 8, 2021
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #137083 has finished for PR 32098 at commit
|
imback82
approved these changes
Apr 8, 2021
|
|
||
| test("try_cast: to_string") { | ||
| assert(TryCast(Literal("1"), IntegerType).toString == "try_cast(1 as int)") | ||
| } |
There was a problem hiding this comment.
It's already verified in the try_cast.sql.out.
|
Test build #137090 has finished for PR 32098 at commit
|
HyukjinKwon
approved these changes
Apr 9, 2021
|
Merging to master |
|
late lgtm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Implement toString() and sql() methods for TRY_CAST
Why are the changes needed?
The new expression should have a different name from
CASTin SQL/String representation.Does this PR introduce any user-facing change?
Yes, in the result of
explain(), users can see try_cast if the new expression is used.How was this patch tested?
Unit tests.