[SPARK-34994][BUILD][2.4] Fix git error when pushing the tag after release script succeeds #32100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
changed the title
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
cc @holdenk |
|
I thought it is only under dry-run. But when I ran with normal run, I also encountered this issue. I checked the working directory at the point, it was wrong and needs |
|
Test build #137096 has finished for PR 32100 at commit
|
|
Ya. Feel free to merge please, @viirya . Release manager can do everything on the release branch to unblock the release. |
|
Thank you @dongjoon-hyun. Merging to branch-2.4. |
viirya
added a commit
that referenced
this pull request
Apr 8, 2021
…lease script succeeds ### What changes were proposed in this pull request? This patch proposes to fix an error when running release-script in 2.4 branch. ### Why are the changes needed? When I ran release script for cutting 2.4.8 RC1, either in dry-run or normal run at the last step "push the tag after success", I encounter the following error: ``` fatal: Not a git repository (or any parent up to mount parent ....) Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). ``` ### Does this PR introduce _any_ user-facing change? No, dev only. ### How was this patch tested? Manual test. Closes #32100 from viirya/fix-release-script-2. Authored-by: Liang-Chi Hsieh <viirya@gmail.com> Signed-off-by: Liang-Chi Hsieh <viirya@gmail.com>
|
LGTM2 |
|
Thank you @HyukjinKwon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch proposes to fix an error when running release-script in 2.4 branch.
Why are the changes needed?
When I ran release script for cutting 2.4.8 RC1, either in dry-run or normal run at the last step "push the tag after success", I encounter the following error:
Does this PR introduce any user-facing change?
No, dev only.
How was this patch tested?
Manual test.