Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-34983][PYTHON] Renaming the package alias from pp to ps #32108

Closed
wants to merge 5 commits into from

Conversation

LSturtew
Copy link
Contributor

@LSturtew LSturtew commented Apr 9, 2021

What changes were proposed in this pull request?

This PR proposes to fix:

import pyspark.pandas as pp

to

import pyspark.pandas as ps

Why are the changes needed?

pp might sound offensive in some contexts.

Does this PR introduce any user-facing change?

The change is in master only. We'll use ps as the short name instead of pp.

How was this patch tested?

The CI in this PR will test it out.

@LSturtew
Copy link
Contributor Author

LSturtew commented Apr 9, 2021

Can one of the admins verify this patch?

@HyukjinKwon HyukjinKwon changed the title [SPARK-34983][PYTHON]Renaming the package alias from pp to ps [SPARK-34983][PYTHON] Renaming the package alias from pp to ps Apr 10, 2021
@HyukjinKwon
Copy link
Member

ok to test

@HyukjinKwon
Copy link
Member

I am fine with dropping mine considering that it's first contribution from @LSturtew. Thanks for your contribution.

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. @itholic and @xinrong-databricks would you mind double checking?

@SparkQA
Copy link

SparkQA commented Apr 10, 2021

Test build #137163 has finished for PR 32108 at commit e1719a5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 10, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41742/

@SparkQA
Copy link

SparkQA commented Apr 10, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41742/

@SparkQA
Copy link

SparkQA commented Apr 10, 2021

Test build #137166 has finished for PR 32108 at commit 5fbd795.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 10, 2021

Test build #137167 has finished for PR 32108 at commit 4a179b6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 10, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41745/

@SparkQA
Copy link

SparkQA commented Apr 10, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41745/

Copy link
Contributor

@itholic itholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @LSturtew !

@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants