New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-34983][PYTHON] Renaming the package alias from pp to ps #32108
Conversation
Can one of the admins verify this patch? |
ok to test |
I am fine with dropping mine considering that it's first contribution from @LSturtew. Thanks for your contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. @itholic and @xinrong-databricks would you mind double checking?
Test build #137163 has finished for PR 32108 at commit
|
Kubernetes integration test starting |
Kubernetes integration test status failure |
Test build #137166 has finished for PR 32108 at commit
|
Test build #137167 has finished for PR 32108 at commit
|
Kubernetes integration test starting |
Kubernetes integration test status failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @LSturtew !
Merged to master. |
What changes were proposed in this pull request?
This PR proposes to fix:
to
Why are the changes needed?
pp
might sound offensive in some contexts.Does this PR introduce any user-facing change?
The change is in master only. We'll use
ps
as the short name instead ofpp
.How was this patch tested?
The CI in this PR will test it out.