Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-35140][INFRA] Add error message guidelines to PR template #32241

Closed
wants to merge 2 commits into from

Conversation

karenfeng
Copy link
Contributor

@karenfeng karenfeng commented Apr 19, 2021

What changes were proposed in this pull request?

Adds a link to the error message guidelines to the PR template to increase visibility.

Why are the changes needed?

Increases visibility of the error message guidelines, which are otherwise hidden in the Contributing guidelines.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Not needed.

Signed-off-by: Karen Feng <karen.feng@databricks.com>
@karenfeng karenfeng changed the title [SPARK-35140] Add error message guidelines to PR template [SPARK-35140][MINOR] Add error message guidelines to PR template Apr 19, 2021
@github-actions github-actions bot added the INFRA label Apr 19, 2021
@SparkQA
Copy link

SparkQA commented Apr 19, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42180/

@SparkQA
Copy link

SparkQA commented Apr 20, 2021

Test build #137651 has finished for PR 32241 at commit 6ef95ac.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Signed-off-by: Karen Feng <karen.feng@databricks.com>
@SparkQA
Copy link

SparkQA commented Apr 20, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42190/

@SparkQA
Copy link

SparkQA commented Apr 20, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42190/

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Apr 20, 2021

Hi, @karenfeng .

  1. Please revise the PR title by following the PR template .
  2. Please remove [MINOR] from the PR title. In the PR title and commit title, [MINOR] is used when we don't have a JIRA ID. It's not a copy of JIRA Priority field. We don't use like [SPARK-XXX][MAJOR].
  3. In this PR, [INFRA] can be used in your PR title like [SPARK-35140][INFRA].

@karenfeng karenfeng changed the title [SPARK-35140][MINOR] Add error message guidelines to PR template [SPARK-35140][INFRA] Add error message guidelines to PR template Apr 20, 2021
@karenfeng
Copy link
Contributor Author

Thanks for the feedback @dongjoon-hyun! I addressed your comments; will keep them in mind next time.

@SparkQA
Copy link

SparkQA commented Apr 20, 2021

Test build #137661 has finished for PR 32241 at commit 5d4bd4a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants