-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-35143][ML] Simplify Python for loop code #32246
Conversation
…nto branch-3.2
…1/spark into branch-3.2 Conflicts: python/pyspark/ml/util.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned earlier in another PR, I don't think this is worthwhile. It's more about style preference.
Can one of the admins verify this patch? |
The file util.py also uses the dictionary + for loop generation at the bottom, and I think it can be simplified in the same way. |
@ChenDou2021 Hi, thanks for the contributions, as mentioned from @HyukjinKwon , the changes in your patch are all coding style preference (also, there were some pros and cons discussion on list comprehes, such as link), so these changes would not be considered to be merged into main line code. Btw, the failing test is due to the branch name is branch-3.2, the fork build test was filtered by
and the notify test can't find the job in your fork repo. If you have futher PR to submit, you should consider rename your branch to something like (SPARK-XXX or other name except branch-XXX). |
ok,I know,thanks
…------------------ 原始邮件 ------------------
发件人: "Yikun ***@***.***>;
发送时间: 2021年4月21日(星期三) 上午9:30
收件人: ***@***.***>;
抄送: ***@***.***>; ***@***.***>;
主题: Re: [apache/spark] [SPARK-35143][ML] Simplify Python for loop code (#32246)
@ChenDou2021 Hi, thanks for the contributions, as mentioned from @HyukjinKwon , the changes in your patch are all coding style preference (also, there were some pros and cons discussion on list comprehes, such as link), so these changes would not be considered to be merged into main line code.
Btw, the failing test is due to the branch name is branch-3.2, the fork build test was filtered by https://github.com/apache/spark/blob/81c3cc2312aaa730fa025159f56703170172c454/.github/workflows/build_and_test.yml#L7
and the notify test can't find the job in your fork repo. If you have futher PR to submit, you should consider rename your branch to something like (SPARK-XXX or other name except branch-XXX).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
And much thanks your first step in Spark community, feel free to open the next PR if you find some other improvements. |
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?