[SPARK-35224][SQL][TESTS] Fix buffer overflow in MutableProjectionSuite
#32339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
|
Test build #137925 has finished for PR 32339 at commit
|
cloud-fan
reviewed
Apr 26, 2021
| val unsafeBuffer = UnsafeRow.createFromByteArray(numBytes, fixedLengthTypes.length) | ||
| val numFields = fixedLengthTypes.length | ||
| val numBytes = Platform.BYTE_ARRAY_OFFSET + UnsafeRow.calculateBitSetWidthInBytes(numFields) + | ||
| UnsafeRow.WORD_SIZE * numFields |
There was a problem hiding this comment.
why did the test pass before?
There was a problem hiding this comment.
It depends how underlying byte array allocated. If you are lucky, you overwrite not important memory of neighbours.
cloud-fan
approved these changes
Apr 26, 2021
|
Merging to master, 3.1/3.0/2.4. |
MaxGekk
added a commit
to MaxGekk/spark
that referenced
this pull request
Apr 26, 2021
…ite` In the test `"unsafe buffer with NO_CODEGEN"` of `MutableProjectionSuite`, fix unsafe buffer size calculation to be able to place all input fields without buffer overflow + meta-data. To make the test suite `MutableProjectionSuite` more stable. No By running the affected test suite: ``` $ build/sbt "test:testOnly *MutableProjectionSuite" ``` Closes apache#32339 from MaxGekk/fix-buffer-overflow-MutableProjectionSuite. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Max Gekk <max.gekk@gmail.com> (cherry picked from commit d572a85) Signed-off-by: Max Gekk <max.gekk@gmail.com>
|
Here is the backport to 3.1/3.0: #32347 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the test
"unsafe buffer with NO_CODEGEN"ofMutableProjectionSuite, fix unsafe buffer size calculation to be able to place all input fields without buffer overflow + meta-data.Why are the changes needed?
To make the test suite
MutableProjectionSuitemore stable.Does this PR introduce any user-facing change?
No
How was this patch tested?
By running the affected test suite: