Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-35311][SS][UI][DOCS] Structured Streaming Web UI state information documentation #32433

Closed
wants to merge 2 commits into from

Conversation

gaborgsomogyi
Copy link
Contributor

@gaborgsomogyi gaborgsomogyi commented May 4, 2021

What changes were proposed in this pull request?

In this PR I'm adding Structured Streaming Web UI state information documentation.

Why are the changes needed?

Missing documentation.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

cd docs/
SKIP_API=1 bundle exec jekyll build

Manual webpage check.

@github-actions github-actions bot added the DOCS label May 4, 2021
@gaborgsomogyi
Copy link
Contributor Author

cc @gatorsmile @HeartSaVioR

@HyukjinKwon HyukjinKwon changed the title [SPARK-35311][SS][UI][DOCS]Structured Streaming Web UI state information documentation [SPARK-35311][SS][UI][DOCS] Structured Streaming Web UI state information documentation May 4, 2021
@SparkQA
Copy link

SparkQA commented May 5, 2021

Test build #138146 has finished for PR 32433 at commit 5616732.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 5, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42667/

@SparkQA
Copy link

SparkQA commented May 5, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42667/

Copy link
Contributor

@HeartSaVioR HeartSaVioR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I'll merge in tomorrow if there's no further comment.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

cc @viirya

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@viirya
Copy link
Member

viirya commented May 6, 2021

BTW, shall we also update the screenshot? Current one (https://raw.githubusercontent.com/apache/spark/56167328dc252f338c0c2fb394c97d63da085283/docs/img/webui-structured-streaming-detail.png) doesn't show the added statistics but just original ones.

@HeartSaVioR
Copy link
Contributor

Nice catch!
@gaborgsomogyi Shall we update the screenshot as well? Thanks!

@gaborgsomogyi
Copy link
Contributor Author

@HeartSaVioR @viirya till now I was fighting to make a screenshot from the whole UI part but I don't have such big screen so I've added an additional image where the rest can be seen.

@gaborgsomogyi
Copy link
Contributor Author

The alternative was to zoom out in the screen but then the UI was super tiny, hard to read and just ugly.

@HeartSaVioR
Copy link
Contributor

Thanks for the update! Looks great.

@viirya Could you please go through the next round of reviews? If there's no additional feedback I'll merge this at the end of the week.

@SparkQA
Copy link

SparkQA commented May 12, 2021

Test build #138446 has finished for PR 32433 at commit e99851d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 12, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42967/

@SparkQA
Copy link

SparkQA commented May 12, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42967/

@HeartSaVioR
Copy link
Contributor

Thanks @gaborgsomogyi ! Merged to master.

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for late. lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants