-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-35311][SS][UI][DOCS] Structured Streaming Web UI state information documentation #32433
Conversation
…ion documentation
Test build #138146 has finished for PR 32433 at commit
|
Kubernetes integration test starting |
Kubernetes integration test status failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
I'll merge in tomorrow if there's no further comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
cc @viirya
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
BTW, shall we also update the screenshot? Current one (https://raw.githubusercontent.com/apache/spark/56167328dc252f338c0c2fb394c97d63da085283/docs/img/webui-structured-streaming-detail.png) doesn't show the added statistics but just original ones. |
Nice catch! |
@HeartSaVioR @viirya till now I was fighting to make a screenshot from the whole UI part but I don't have such big screen so I've added an additional image where the rest can be seen. |
The alternative was to zoom out in the screen but then the UI was super tiny, hard to read and just ugly. |
Thanks for the update! Looks great. @viirya Could you please go through the next round of reviews? If there's no additional feedback I'll merge this at the end of the week. |
Test build #138446 has finished for PR 32433 at commit
|
Kubernetes integration test starting |
Kubernetes integration test status failure |
Thanks @gaborgsomogyi ! Merged to master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for late. lgtm.
What changes were proposed in this pull request?
In this PR I'm adding Structured Streaming Web UI state information documentation.
Why are the changes needed?
Missing documentation.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual webpage check.