Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-35306][MLLIB][TESTS] Add benchmark results for BLASBenchmark created by GitHub Actions machines #32435

Closed
wants to merge 1 commit into from

Conversation

byungsoo-oh
Copy link

What changes were proposed in this pull request?

This PR adds benchmark results for BLASBenchmark created by GitHub Actions machines.
Benchmark result files are added for both JDK 8 (BLASBenchmark-result.txt) and 11 (BLASBenchmark-jdk11-result.txt) in {SPARK_HOME}/mllib-local/benchmarks/.

Why are the changes needed?

In SPARK-34950, benchmark results were updated to the ones created by Github Actions machines.
As benchmark results for BLASBenchmark (added at SPARK-33882 and SPARK-35150) are not currently available at the repository, this PR adds them.

Does this PR introduce any user-facing change?

No

How was this patch tested?

The benchmark results were obtained by running tests with GitHub Actions workflow in my forked repository.
You can refer to the test results and output files from the link below.

@github-actions github-actions bot added the MLLIB label May 4, 2021
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @byungsoo-oh .

cc @HyukjinKwon

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-35306][TESTS] Add benchmark results for BLASBenchmark created by GitHub Actions machines [SPARK-35306][MLLIB][TESTS] Add benchmark results for BLASBenchmark created by GitHub Actions machines May 6, 2021
@HyukjinKwon
Copy link
Member

Merged to master.

@dongjoon-hyun
Copy link
Member

Thank you, @byungsoo-oh and @HyukjinKwon !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants