[SPARK-35387][INFRA] Increase the JVM stack size for Java 11 build test #32521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's late here now. I need to go to bed. Let's see if the problem can be resolved by this PR. If not, please help reverting #32439 . |
|
Thank you, @gengliangwang . |
|
Java11 Passed. Merged to master. |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Thanks, Gengliang! |
|
Test build #138464 has finished for PR 32521 at commit
|
27 tasks
gengliangwang
added a commit
that referenced
this pull request
Jun 9, 2021
### What changes were proposed in this pull request? The jenkins SBT/Maven build keep failing with stack overflow error: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139542 We should increase the JVM stack size to 16MB. Also, #32521 set the stack size to 256MB for Java 11 build, which might be too big since every thread will allocate this memory for the stack. This PR also set it as 16MB to make the config consistent. ### Why are the changes needed? Fix SBT/Maven build. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Jenkins and GA tests. Closes #32838 from gengliangwang/increaseSBTStackSize. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Gengliang Wang <gengliang@apache.org>
a0x8o
added a commit
to a0x8o/spark
that referenced
this pull request
Jun 9, 2021
### What changes were proposed in this pull request? The jenkins SBT/Maven build keep failing with stack overflow error: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139542 We should increase the JVM stack size to 16MB. Also, apache/spark#32521 set the stack size to 256MB for Java 11 build, which might be too big since every thread will allocate this memory for the stack. This PR also set it as 16MB to make the config consistent. ### Why are the changes needed? Fix SBT/Maven build. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Jenkins and GA tests. Closes #32838 from gengliangwang/increaseSBTStackSize. Authored-by: Gengliang Wang <gengliang@apache.org> Signed-off-by: Gengliang Wang <gengliang@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
After merging #32439, there is flaky error from the Github action job "Java 11 build with Maven":
We can resolve it by increasing the stack size of JVM to 256M. The container for Github action jobs has 7G memory so this should be fine.
Why are the changes needed?
Fix flaky test failure in Java 11 build test
Does this PR introduce any user-facing change?
No
How was this patch tested?
Github action test