-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-34941][PYTHON] Fix mypy errors and enable mypy check for pandas-on-Spark. #32540
Conversation
Test build #138520 has finished for PR 32540 at commit
|
Kubernetes integration test starting |
Kubernetes integration test status failure |
Test build #138523 has finished for PR 32540 at commit
|
Kubernetes integration test starting |
Kubernetes integration test status failure |
Test build #138524 has finished for PR 32540 at commit
|
cc @HyukjinKwon @itholic @xinrong-databricks |
Kubernetes integration test starting |
Kubernetes integration test status failure |
Test build #138526 has finished for PR 32540 at commit
|
Kubernetes integration test starting |
Kubernetes integration test status failure |
Also cc @zero323 |
Thanks! merging to master. |
What changes were proposed in this pull request?
Fixes
mypy
errors and enablesmypy
check for pandas-on-Spark.Why are the changes needed?
The
mypy
check for pandas-on-Spark was disabled when the initial porting.It should be enabled again; otherwise we will miss type checking errors.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
The enabled
mypy
check and existing unit tests should pass.