Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-34941][PYTHON] Fix mypy errors and enable mypy check for pandas-on-Spark. #32540

Closed
wants to merge 5 commits into from

Conversation

ueshin
Copy link
Member

@ueshin ueshin commented May 13, 2021

What changes were proposed in this pull request?

Fixes mypy errors and enables mypy check for pandas-on-Spark.

Why are the changes needed?

The mypy check for pandas-on-Spark was disabled when the initial porting.
It should be enabled again; otherwise we will miss type checking errors.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

The enabled mypy check and existing unit tests should pass.

@SparkQA
Copy link

SparkQA commented May 13, 2021

Test build #138520 has finished for PR 32540 at commit 626f21e.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 13, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43041/

@SparkQA
Copy link

SparkQA commented May 13, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43041/

@SparkQA
Copy link

SparkQA commented May 13, 2021

Test build #138523 has finished for PR 32540 at commit 1e5a0f3.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 13, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43044/

@SparkQA
Copy link

SparkQA commented May 13, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43044/

@SparkQA
Copy link

SparkQA commented May 13, 2021

Test build #138524 has finished for PR 32540 at commit 607b57a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@ueshin ueshin marked this pull request as ready for review May 13, 2021 20:56
@ueshin ueshin requested a review from HyukjinKwon May 13, 2021 20:56
@ueshin
Copy link
Member Author

ueshin commented May 13, 2021

cc @HyukjinKwon @itholic @xinrong-databricks

@SparkQA
Copy link

SparkQA commented May 13, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43045/

@SparkQA
Copy link

SparkQA commented May 13, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43045/

@SparkQA
Copy link

SparkQA commented May 13, 2021

Test build #138526 has finished for PR 32540 at commit 6a0b9c0.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented May 13, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43047/

@SparkQA
Copy link

SparkQA commented May 13, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43047/

@HyukjinKwon
Copy link
Member

Also cc @zero323

@ueshin
Copy link
Member Author

ueshin commented May 17, 2021

Thanks! merging to master.

@ueshin ueshin closed this in 2a335f2 May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants