Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-35424][SHUFFLE] Remove some useless code in the ExternalBlockHandler. #32571

Closed
wants to merge 1 commit into from
Closed

[SPARK-35424][SHUFFLE] Remove some useless code in the ExternalBlockHandler. #32571

wants to merge 1 commit into from

Conversation

weixiuli
Copy link
Contributor

@weixiuli weixiuli commented May 17, 2021 •
edited

What changes were proposed in this pull request?

Remove some useless code in the ExternalBlockHandler.

Why are the changes needed?

There is some useless code in the ExternalBlockHandler, so we may remove it.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Exist unittests.

@github-actions github-actions bot added the CORE label May 17, 2021
@weixiuli weixiuli changed the title [SPARK-35424][SHUFFLE] Remove some useless code in ExternalBlockHandler. [SPARK-35424][SHUFFLE] Remove some useless code in the ExternalBlockHandler. May 17, 2021
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

srowen
srowen reviewed May 17, 2021
View reviewed changes
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't appear to be used, yes. I think this is also a pretty internal class and module, so probably OK, but is it worth removing just in case? it could be deprecated instead just to be safe.

@weixiuli
Copy link
Contributor Author

@srowen @Approval do you have any questions, thanks.

@HyukjinKwon
Copy link
Member

Merged to master.

@weixiuli
Copy link
Contributor Author

Thank you so much ! @HyukjinKwon @srowen @mridulm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srowen srowen srowen left review comments

@mridulm mridulm mridulm approved these changes

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees
No one assigned
Labels
CORE
Projects
None yet
Milestone
No milestone
5 participants
@weixiuli @AmplabJenkins @HyukjinKwon @srowen @mridulm