Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-35373][BUILD][FOLLOWUP][3.1] Update zinc installation #32591

Closed
wants to merge 1 commit into from
Closed

[SPARK-35373][BUILD][FOLLOWUP][3.1] Update zinc installation #32591

wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented May 19, 2021

What changes were proposed in this pull request?

This PR is a follow-up of #32505 to fix zinc installation.

Why are the changes needed?

Currently, branch-3.1/3.0 is broken.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the GitHub Action.

@github-actions github-actions bot added the BUILD label May 19, 2021
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-35373][BUILD][FOLLOWUP] Update zinc installation [SPARK-35373][BUILD][FOLLOWUP][3.1] Update zinc installation May 19, 2021
@dongjoon-hyun
Copy link
Member Author

cc @srowen

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, right. This looks right, let's see if tests are OK. This would need to go to 3.0 too then.

@dongjoon-hyun
Copy link
Member Author

Thank you, @srowen . Yep, branch-3.0, too.

@srowen
Copy link
Member

srowen commented May 19, 2021

Thank you for fixing, my bad!

@dongjoon-hyun
Copy link
Member Author

Thank you, @HyukjinKwon and @srowen .
(No problem at all, @srowen . 😄 )

Since the downloading part passed, I'll merge this.

dongjoon-hyun added a commit that referenced this pull request May 19, 2021
### What changes were proposed in this pull request?

This PR is a follow-up of #32505 to fix `zinc` installation.

### Why are the changes needed?

Currently, branch-3.1/3.0 is broken.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the GitHub Action.

Closes #32591 from dongjoon-hyun/SPARK-35373.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dongjoon-hyun added a commit that referenced this pull request May 19, 2021
### What changes were proposed in this pull request?

This PR is a follow-up of #32505 to fix `zinc` installation.

### Why are the changes needed?

Currently, branch-3.1/3.0 is broken.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the GitHub Action.

Closes #32591 from dongjoon-hyun/SPARK-35373.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit 50edf12)
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
@dongjoon-hyun
Copy link
Member Author

Merged to branch-3.1/3.0.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-35373 branch May 19, 2021 16:53
@SparkQA
Copy link

SparkQA commented May 19, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43235/

@SparkQA
Copy link

SparkQA commented May 19, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43235/

flyrain pushed a commit to flyrain/spark that referenced this pull request Sep 21, 2021
### What changes were proposed in this pull request?

This PR is a follow-up of apache#32505 to fix `zinc` installation.

### Why are the changes needed?

Currently, branch-3.1/3.0 is broken.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the GitHub Action.

Closes apache#32591 from dongjoon-hyun/SPARK-35373.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
flyrain pushed a commit to flyrain/spark that referenced this pull request Sep 21, 2021
### What changes were proposed in this pull request?

This PR is a follow-up of apache#32505 to fix `zinc` installation.

### Why are the changes needed?

Currently, branch-3.1/3.0 is broken.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the GitHub Action.

Closes apache#32591 from dongjoon-hyun/SPARK-35373.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants