[SPARK-32975] [K8S] Ensure driver is ready before executors start #32739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before creating executor pods, wait until driver gets ready. The driver's headless service can be resolved by DNS only after the driver pod is ready. If the executor tries to connect to the headless service before driver pod is ready, it will hit UnkownHostException and get into error state but will not be restarted.
|
Can one of the admins verify this patch? |
|
This only addresses driver, what about executors if they have sidecar injected too? The executor must wait as well before sidecar container is ready and then make bootstrap calls to driver. I was getting connection refused excp because sidecar container was not ready and executor was trying to communicate. I resolved it by adding a sleep/wait time in entrypoint.sh for exec, but it would be neat to have a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Before creating executor pods, wait until the driver pod is ready.
Why are the changes needed?
The driver's headless service can be resolved by DNS only after the driver pod is ready. If the executor tries to connect to the headless service before driver pod is ready, it will hit UnkownHostException and get into error state but will not be restarted. This case usually happens when the driver pod has sidecar containers but hasn't finished their creation when executors start. So basically there is a race condition.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Exisiting tests.