Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-21957][SQL][FOLLOWUP] Support CURRENT_USER without tailing parentheses #32770

Closed
wants to merge 3 commits into from

Conversation

yaooqinn
Copy link
Member

@yaooqinn yaooqinn commented Jun 3, 2021

What changes were proposed in this pull request?

A followup for 345d35e, in this PR we support CURRENT_USER without tailing parentheses in default mode. And for ANSI mode, we can only use CURRENT_USER without tailing parentheses because it is a reserved keyword that cannot be used as a function name

Why are the changes needed?

  1. make it the same as current_date/current_timestamp
  2. better ANSI compliance

Does this PR introduce any user-facing change?

no, just a followup

How was this patch tested?

new tests

@github-actions github-actions bot added the SQL label Jun 3, 2021
@SparkQA
Copy link

SparkQA commented Jun 3, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43813/

@SparkQA
Copy link

SparkQA commented Jun 3, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43813/

@SparkQA
Copy link

SparkQA commented Jun 3, 2021

Test build #139289 has finished for PR 32770 at commit 25df635.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@yaooqinn
Copy link
Member Author

yaooqinn commented Jun 4, 2021

cc @cloud-fan

@SparkQA
Copy link

SparkQA commented Jun 4, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43845/

@SparkQA
Copy link

SparkQA commented Jun 4, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43845/

@SparkQA
Copy link

SparkQA commented Jun 4, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43852/

@SparkQA
Copy link

SparkQA commented Jun 4, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43852/

@SparkQA
Copy link

SparkQA commented Jun 4, 2021

Test build #139323 has finished for PR 32770 at commit d567bbe.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 4, 2021

Test build #139330 has finished for PR 32770 at commit 6e4b021.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in dc3317f Jun 4, 2021
@yaooqinn yaooqinn deleted the SPARK-21957-F branch June 4, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants