Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-35655][BUILD] Upgrade HtmlUnit and its related artifacts to 2.50 #32789

Closed
wants to merge 1 commit into from

Conversation

sarutak
Copy link
Member

@sarutak sarutak commented Jun 5, 2021

What changes were proposed in this pull request?

This PR upgrades HtmlUnit and its related artifacts to 2.50.

Why are the changes needed?

We currently uses 2.40 but 2.41+ seem to include bunch of bug fixes and improvements especially for JavaScript and CSS.
https://htmlunit.sourceforge.io/changes-report.html#a2.50.0

Does this PR introduce any user-facing change?

No.

How was this patch tested?

All the UISeleniumSuite which use HtmlUnit pass on my laptop.

@github-actions github-actions bot added the BUILD label Jun 5, 2021
@sarutak sarutak changed the title Upgrade htmlunit to 2.50.0. [SPARK-35655][BUILD] Upgrade HtmlUnit and its related artifacts to 2.50 Jun 5, 2021
@gengliangwang
Copy link
Member

@sarutak I am seeing some error message in https://github.com/sarutak/spark/actions/runs/907529561
Are they related?

@sarutak
Copy link
Member Author

sarutak commented Jun 5, 2021

@gengliangwang I don't think so. I've noticed sometimes, such InterruptedException happens but seems not to affect the result.
https://github.com/dongjoon-hyun/spark/actions/runs/906863634
https://github.com/dgd-contributor/spark/actions/runs/902021834
https://github.com/cloud-fan/spark/actions/runs/901318886

@SparkQA
Copy link

SparkQA commented Jun 5, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43889/

@SparkQA
Copy link

SparkQA commented Jun 5, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43889/

@SparkQA
Copy link

SparkQA commented Jun 5, 2021

Test build #139367 has finished for PR 32789 at commit d4d0c07.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gengliangwang
Copy link
Member

Thanks, merging to master

HyukjinKwon pushed a commit that referenced this pull request Jul 4, 2022
…2.50.0 to 2.62.0

### What changes were proposed in this pull request?
This PR upgrades HtmlUnit and its related artifacts from 2.50.0 to 2.62.0.
The last upgrade occurred 1 year and 1 month ago. #32789

### Why are the changes needed?
We currently uses 2.50 but 2.51+ seem to include bunch of bug fixes and improvements especially for JavaScript and CSS.
Especially with the browser(Chrome/Edge/Firefox ) upgrade in the past year.
release notes: https://htmlunit.sourceforge.io/changes-report.html#a2.62.0

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
All the UISeleniumSuite which use HtmlUnit pass.

Closes #37059 from panbingkun/upgrade-htmlunit.

Authored-by: panbingkun <pbk1982@gmail.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants