Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-35697][SQL][TESTS] Test TimestampWithoutTZType as ordered and atomic type #32843

Closed
wants to merge 2 commits into from

Conversation

gengliangwang
Copy link
Member

What changes were proposed in this pull request?

Add TimestampWithoutTZType to DataTypeTestUtils.ordered/atomicTypes, and implement values generation of those types in LiteralGenerator/RandomDataGenerator. In this way, the types will be tested automatically in:

  1. ArithmeticExpressionSuite:
    • "function least"
    • "function greatest"
  2. PredicateSuite
    • "BinaryComparison consistency check"
    • "AND, OR, EqualTo, EqualNullSafe consistency check"
  3. ConditionalExpressionSuite
    • "if"
  4. RandomDataGeneratorSuite
    • "Basic types"
  5. CastSuite
    • "null cast"
    • "up-cast"
    • "SPARK-27671: cast from nested null type in struct"
  6. OrderingSuite
    • "GenerateOrdering with TimestampWithoutTZType"
  7. PredicateSuite
    • "IN with different types"
  8. UnsafeRowSuite
    • "calling get(ordinal, datatype) on null columns"
  9. SortSuite
    • "sorting on TimestampWithoutTZType ..."

Why are the changes needed?

To improve test coverage.

Does this PR introduce any user-facing change?

No

How was this patch tested?

By running the affected test suites.

@gengliangwang
Copy link
Member Author

This one is to follow #31782

@github-actions github-actions bot added the SQL label Jun 9, 2021
@SparkQA
Copy link

SparkQA commented Jun 9, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44101/

@SparkQA
Copy link

SparkQA commented Jun 9, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44101/

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in 313dc2d Jun 9, 2021
@SparkQA
Copy link

SparkQA commented Jun 9, 2021

Test build #139574 has finished for PR 32843 at commit 6a4fc48.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants