[SPARK-35716][SQL] Support casting of timestamp without time zone to date type #32869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengliangwang
commented
Jun 10, 2021
| @@ -1256,10 +1256,17 @@ abstract class AnsiCastSuiteBase extends CastSuiteBase { | |||
|
|
|||
| test("SPARK-35711: cast timestamp without time zone to timestamp with local time zone") { | |||
| specialTs.foreach { s => | |||
| val dt = LocalDateTime.parse(s.replace(" ", "T")) | |||
| val dt = LocalDateTime.parse(s) | |||
There was a problem hiding this comment.
This is a trivial change for the test case. There is no need to replace the space.
cloud-fan
reviewed
Jun 10, 2021
| case TimestampWithoutTZType => | ||
| (c, evPrim, evNull) => | ||
| // scalastyle:off line.size.limit | ||
| code"$evPrim = org.apache.spark.sql.catalyst.util.DateTimeUtils.microsToDays($c, java.time.ZoneOffset.UTC);" |
There was a problem hiding this comment.
nit: we can add a protected def dtUtilCls = classOf[DateTimeUtils].getClass.getName in CaseBase, to shorten the code here and other places.
cloud-fan
approved these changes
Jun 10, 2021
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
MaxGekk
approved these changes
Jun 10, 2021
|
+1, LGTM. Merging to master. |
|
Test build #139653 has finished for PR 32869 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Extend the Cast expression and support TimestampWithoutTZType in casting to DateType.
Why are the changes needed?
To conform the ANSI SQL standard which requires to support such casting.
Does this PR introduce any user-facing change?
No, the new timestamp type is not released yet.
How was this patch tested?
Unit test