[SPARK-35720][SQL] Support casting of String to timestamp without time zone type #32898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
HyukjinKwon
changed the title
|
|
||
| test("SPARK-35720: Support casting of String to timestamp without time zone type") { | ||
| specialTs.foreach { s => |
There was a problem hiding this comment.
As I mentioned in https://issues.apache.org/jira/browse/SPARK-35720, I don't think we can simply use stringToTimestamp here. You will find that when you have more test cases here.
There was a problem hiding this comment.
@gengliangwang thanks for the review. Will update ASAP.
|
@pingsutw any update on this? The project of |
|
@gengliangwang Sorry, I was in the army a couple days ago. |
|
@pingsutw It's OK :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Extend the Cast expression and support casting of String to timestamp without time zone type
Why are the changes needed?
To conform the ANSI SQL standard which requires to support such casting.
Does this PR introduce any user-facing change?
No, the new timestamp type is not released yet.
How was this patch tested?
Unit test