[SPARK-35778][SQL][TESTS] Check multiply/divide of year month interval of any fields by numeric #33051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peng-Lei
changed the title
Peng-Lei
changed the title
|
Can one of the admins verify this patch? |
Peng-Lei
changed the title
Peng-Lei
changed the title
|
I also think when the same Period convert to different year month interval should be different value to store. So I also think the PR is wrong. we should wait the another PR，then rewite this PR change. |
|
@AngersZhuuuu @Peng-Lei How about this #33014 . Is it wrong too? |
Yes, In #33056 I have ignore these two pr's change, and after merge #33056, we will raise follow up to revert current wrong change and add correct UT. |
|
Here are 2 reverts:
@cloud-fan @HyukjinKwon @sarutak May I ask you to approve them, please. |
|
@Peng-Lei Next time, let's add checks for year-month and day-time interval types in one PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Check multiply/divide of year-month intervals of any fields by numeric.
Why are the changes needed?
To improve test coverage.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Expanded existed test cases.