[SPARK-35728][SPARK-35778][SQL][TESTS] Check multiply/divide of day-time and year-month interval of any fields by a numeric #33080
Conversation
|
@AngersZhuuuu @MaxGekk I tried to test multiply/divide of day-time intervals of any fields by numeric in two ways. First method is simple, but it is incomplete, because it does not use |
|
ok to test |
| } | ||
| } | ||
|
|
||
| test("SPARK-35778: Check multiply/divide of year-month intervals of any fields by numeric 1") { |
There was a problem hiding this comment.
Why have two ut for this?
There was a problem hiding this comment.
I tried to test multiply/divide of day-time intervals of any fields by numeric in two ways. First method is simple, but it is incomplete, because it does not use checkEvaluation. just compare the eval(). Second method is enumerate data to test. I'll delete one way, what about your suggestion? Thank you.
| } | ||
| } | ||
|
|
||
| test("SPARK-35778: Check multiply/divide of year-month intervals of any fields by numeric 2") { |
There was a problem hiding this comment.
This UT seems can cover all type field of YearMonthIntervalType
|
Can one of the admins verify this patch? |
Check multiply/divide day time interval and year month interval type of any fields by numeric
Peng-Lei
force-pushed
the
SPARK-35728-35778
branch
from
175a5f6
to
308f44d
Compare
MaxGekk
changed the title
MaxGekk
changed the title
MaxGekk
changed the title
|
+1, LGTM. Merging to master. |
MaxGekk
changed the title
What changes were proposed in this pull request?
SPARK-35728: Add test case to check multiply/divide of day-time
intervals of any fields by numeric
SPARK-35778: Add test case to check multiply/divide of year-month intervals of any fields by numeric
Why are the changes needed?
Improve test coverage
Does this PR introduce any user-facing change?
No
How was this patch tested?
Add ut tests
Lead-authored-by: Lei Peng peng.8lei@gmail.com
Co-authored-by: AngersZhuuuu angers.zhu@gmail.com