Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-35895][SQL] Support subtracting Intervals from TimestampWithoutTZ #33086

Closed
wants to merge 1 commit into from

Conversation

gengliangwang
Copy link
Member

What changes were proposed in this pull request?

Support the following operation:

  • TimestampWithoutTZ - Year-Month interval

The following operation is actually supported in #33076. This PR is to add end-to-end tests for them:

  • TimestampWithoutTZ - Calendar interval
  • TimestampWithoutTZ - Daytime interval

Why are the changes needed?

Support subtracting all 3 interval types from a timestamp without time zone

Does this PR introduce any user-facing change?

No, the timestamp without time zone type is not release yet.

How was this patch tested?

Unit tests

@github-actions github-actions bot added the SQL label Jun 25, 2021
@gengliangwang gengliangwang changed the title [SPARK-35895][SQL] [SPARK-35895][SQL] Support subtracting Intervals from TimestampWithoutTZ Jun 25, 2021
@SparkQA
Copy link

SparkQA commented Jun 25, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44855/

@SparkQA
Copy link

SparkQA commented Jun 25, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44855/

@SparkQA
Copy link

SparkQA commented Jun 25, 2021

Test build #140323 has finished for PR 33086 at commit 55ce2b6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@MaxGekk
Copy link
Member

MaxGekk commented Jun 26, 2021

The build failure by Scala 2.13:

[error] /home/runner/work/spark/spark/core/src/main/scala/org/apache/spark/SparkContext.scala:428:30: type mismatch;
[error]  found   : Seq[String] (in scala.collection) 
[error]  required: Seq[String] (in scala.collection.immutable) 
[error]     _jars = Utils.getUserJars(_conf)

is not related to the changes, I think.

@MaxGekk
Copy link
Member

MaxGekk commented Jun 26, 2021

+1, LGTM. Merging to master.
Thank you, @gengliangwang .

@MaxGekk MaxGekk closed this in 645fb59 Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants