Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-35859][PYTHON] Cleanup type hints in pandas-on-Spark #33117

Closed
wants to merge 10 commits into from

Conversation

ueshin
Copy link
Member

@ueshin ueshin commented Jun 28, 2021

What changes were proposed in this pull request?

Cleaning up the type hints in pandas-on-Spark.

  • Use a single file _typing.py for type variables or aliases
  • Rename IndexOpsLike to SeriesOrIndex.
  • Rename T_Frame and T_IndexOps to FrameLike and IndexOpsLike respectively
  • Introduce DataFrameOrSeries for Union[DataFrame, Series]

Why are the changes needed?

This is a cleanup for the mypy check stuff series.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing tests.

@ueshin ueshin marked this pull request as ready for review June 28, 2021 23:57
@ueshin
Copy link
Member Author

ueshin commented Jun 28, 2021

cc @HyukjinKwon @itholic @xinrong-databricks

@ueshin
Copy link
Member Author

ueshin commented Jun 29, 2021

Thanks! merging to master.

@ueshin ueshin closed this in 2702fb9 Jun 29, 2021
@AmplabJenkins
Copy link

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44888/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants