[SPARK-35990][BUILD] Remove avro-sbt plugin dependency #33190
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR removes sbt-avro plugin dependency.
In the current master, Build with SBT depends on the plugin but it seems never used.
Originally, the plugin was introduced for
flume-sink
in SPARK-1729 (#807) butflume-sink
is no longer in Spark repository.After SBT was upgraded to 1.x in SPARK-21708 (#29286),
avroGenerate
part was introduced inobject SQL
inSparkBuild.scala
.It's confusable but I understand
Test / avroGenerate := (Compile / avroGenerate).value
is for suppressing sbt-avro forsql
sub-module.In fact, Test/compile will fail if
Test / avroGenerate :=(Compile / avroGenerate).value
is commented out.sql
sub-module containsparquet-compat.avpr
andparquet-compat.avdl
but according tosql/core/src/test/README.md
, they are intended to be handled bygen-avro.sh
.Also, in terms of Maven build, there seems to be no definition to handle
*.avpr
or*.avdl
.Based on the above, I think we can remove
sbt-avro
.Why are the changes needed?
If
sbt-avro
is really no longer used, it's confusable thatsbt-avro
related configurations are inSparkBuild.scala
.Does this PR introduce any user-facing change?
No.
How was this patch tested?
GA.