Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-36021][SQL][FOLLOWUP] DT/YM func use field byte to keep consistence #33252

Closed
wants to merge 2 commits into from

Conversation

AngersZhuuuu
Copy link
Contributor

What changes were proposed in this pull request?

With more thought, all DT/YM function use field byte to keep consistence is better

Why are the changes needed?

Keep code consistence

Does this PR introduce any user-facing change?

No

How was this patch tested?

Not need

@github-actions github-actions bot added the SQL label Jul 8, 2021
@AngersZhuuuu
Copy link
Contributor Author

@MaxGekk @cloud-fan Should we keep IntervalUnit now after we have DT/YM field byte now? after this pr's code, it's only usage is as string value

  object IntervalUnit extends Enumeration {
    type IntervalUnit = Value

    val NANOSECOND = Value(0, "nanosecond")
    val MICROSECOND = Value(1, "microsecond")
    val MILLISECOND = Value(2, "millisecond")
    val SECOND = Value(3, "second")
    val MINUTE = Value(4, "minute")
    val HOUR = Value(5, "hour")
    val DAY = Value(6, "day")
    val WEEK = Value(7, "week")
    val MONTH = Value(8, "month")
    val YEAR = Value(9, "year")
  }

@SparkQA
Copy link

SparkQA commented Jul 8, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45283/

@SparkQA
Copy link

SparkQA commented Jul 8, 2021

Test build #140771 has finished for PR 33252 at commit 9e07e88.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AngersZhuuuu
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented Jul 8, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45285/

@SparkQA
Copy link

SparkQA commented Jul 8, 2021

Test build #140773 has finished for PR 33252 at commit 9e07e88.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 8, 2021

Test build #140776 has finished for PR 33252 at commit 0582bda.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AngersZhuuuu
Copy link
Contributor Author

retest this please

@SparkQA
Copy link

SparkQA commented Jul 8, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45288/

@SparkQA
Copy link

SparkQA commented Jul 8, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45290/

@SparkQA
Copy link

SparkQA commented Jul 8, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45288/

@SparkQA
Copy link

SparkQA commented Jul 8, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45290/

@MaxGekk
Copy link
Member

MaxGekk commented Jul 8, 2021

Should we keep IntervalUnit now after we have DT/YM field byte now?

@AngersZhuuuu If it is possible, let's delete it (in another PR).

@MaxGekk MaxGekk closed this in 89aa16b Jul 8, 2021
MaxGekk pushed a commit that referenced this pull request Jul 8, 2021
…tence

### What changes were proposed in this pull request?
With more thought, all DT/YM function use field byte to keep consistence is better

### Why are the changes needed?
Keep code consistence

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Not need

Closes #33252 from AngersZhuuuu/SPARK-36021-FOLLOWUP.

Authored-by: Angerszhuuuu <angers.zhu@gmail.com>
Signed-off-by: Max Gekk <max.gekk@gmail.com>
(cherry picked from commit 89aa16b)
Signed-off-by: Max Gekk <max.gekk@gmail.com>
@SparkQA
Copy link

SparkQA commented Jul 8, 2021

Test build #140778 has finished for PR 33252 at commit 0582bda.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants