[SPARK-36075][K8S] Support for specifiying executor/driver node selector #33283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #140858 has started for PR 33283 at commit |
|
Kubernetes integration test unable to build dist. exiting with code: 141 |
|
Test build #140877 has finished for PR 33283 at commit
|
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
dongjoon-hyun
approved these changes
Jul 18, 2021
There was a problem hiding this comment.
+1, LGTM. Thank you, @Yikun .
Sorry for the delay. I was on vacation last week.
Merged to master for Apache Spark 3.3.0.
ejblanco
pushed a commit
to Telefonica/spark
that referenced
this pull request
Feb 28, 2022
### What changes were proposed in this pull request? Add the support for specifiying executor/driver node selector: - spark.kubernetes.driver.node.selector. - spark.kubernetes.executor.node.selector. ### Why are the changes needed? Now we can only use "spark.kubernetes.node.selector" to set lable for executor/driver. Sometimes, we need set executor/driver pods to different selector separately. ### Does this PR introduce _any_ user-facing change? Yes ### How was this patch tested? - KubernetesConfSuite for new added configure - BasicDriverFeatureStepSuite to make sure driver pods node selector set properly - BasicExecutorFeatureStepSuite to make sure excutor pods node selector set properly Closes apache#33283 from Yikun/SPARK-36075. Authored-by: Yikun Jiang <yikunkero@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the support for specifiying executor/driver node selector:
Why are the changes needed?
Now we can only use "spark.kubernetes.node.selector" to set lable for executor/driver. Sometimes, we need set executor/driver pods to different selector separately.
Does this PR introduce any user-facing change?
Yes
How was this patch tested?