Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-36122][CORE] Passing on needClientAuth to Jetty SSLContextFactory #33301

Closed
wants to merge 1 commit into from

Conversation

skhandrikagmail
Copy link
Contributor

@skhandrikagmail skhandrikagmail commented Jul 12, 2021

SPARK-36122: Spark does not passon needClientAuth to Jetty SSLContextFactory. Does not allow to configure mTLS authentication.

passing needClientAuth to sslContextFactory would help enable mTLS authentication for Jetty through x509 certificates.

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

passing needClientAuth to sslContextFactory would help enable mTLS authentication for Jetty through x509 certificates.
@github-actions github-actions bot added the CORE label Jul 12, 2021
@HyukjinKwon
Copy link
Member

@skhandrikagmail, please fill the PR description and format PR title with a JIRA number, see also https://spark.apache.org/contributing.html

@srowen
Copy link
Member

srowen commented Jul 14, 2021

Jenkins test this please

@SparkQA
Copy link

SparkQA commented Jul 14, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45535/

@SparkQA
Copy link

SparkQA commented Jul 14, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45535/

@SparkQA
Copy link

SparkQA commented Jul 14, 2021

Test build #141020 has finished for PR 33301 at commit 55f7200.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

@skhandrikagmail, can you address #33301 (comment) please?

@skhandrikagmail skhandrikagmail changed the title Update SSLOptions.scala SPARK-36122: Passing on needClientAuth to Jetty SSLContextFactory Jul 16, 2021
@skhandrikagmail
Copy link
Contributor Author

@skhandrikagmail, can you address #33301 (comment) please?

Done. Updated the PR title too with JIRA number.

@srowen srowen changed the title SPARK-36122: Passing on needClientAuth to Jetty SSLContextFactory [SPARK-36122][CORE] Passing on needClientAuth to Jetty SSLContextFactory Jul 16, 2021
@srowen
Copy link
Member

srowen commented Jul 16, 2021

Jenkins test this please

@SparkQA
Copy link

SparkQA commented Jul 16, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45669/

@SparkQA
Copy link

SparkQA commented Jul 16, 2021

Test build #141157 has finished for PR 33301 at commit 55f7200.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@skhandrikagmail skhandrikagmail marked this pull request as draft July 16, 2021 22:14
@skhandrikagmail skhandrikagmail marked this pull request as ready for review July 16, 2021 22:14
@srowen
Copy link
Member

srowen commented Jul 17, 2021

Merged to master

@srowen srowen closed this in bfdde96 Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants