[SPARK-36130][SQL] UnwrapCastInBinaryComparison should skip In expression when in.list contains an expression that is not literal

[cfmcgrady]

What changes were proposed in this pull request?

Fix comment
This PR fix rule UnwrapCastInBinaryComparison bug. Rule UnwrapCastInBinaryComparison should skip In expression when in.list contains an expression that is not literal.

• In

Before this pr, the following example will throw an exception.

  withTable("tbl") {
    sql("CREATE TABLE tbl (d decimal(33, 27)) USING PARQUET")
    sql("SELECT d FROM tbl WHERE d NOT IN (d + 1)")
  }

• InSet

As the analyzer guarantee that all the elements in the inSet.hset are literal, so this is not an issue for InSet.

spark/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/expressions.scala

Lines 264 to 279 in fbf53de

	case expr @ In(v, list) if expr.inSetConvertible =>
	val newList = ExpressionSet(list).toSeq
	if (newList.length == 1
	// TODO: `EqualTo` for structural types are not working. Until SPARK-24443 is addressed,
	// TODO: we exclude them in this rule.
	&& !v.isInstanceOf[CreateNamedStruct]
	&& !newList.head.isInstanceOf[CreateNamedStruct]) {
	EqualTo(v, newList.head)
	} else if (newList.length > conf.optimizerInSetConversionThreshold) {
	val hSet = newList.map(e => e.eval(EmptyRow))
	InSet(v, HashSet() ++ hSet)
	} else if (newList.length < list.length) {
	expr.copy(list = newList)
	} else { // newList.length == list.length && newList.length > 1
	expr
	}

Does this PR introduce any user-facing change?

No, only bug fix.

How was this patch tested?

New test.

[AmplabJenkins]

Can one of the admins verify this patch?

[cfmcgrady]

cc @allisonwang-db @cloud-fan

[cloud-fan]

thanks for the quick fix!

[cloud-fan]

merging to maste/3.2