-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-36093][SQL][3.1] RemoveRedundantAliases should not change Command's parameter's expression's name #33417
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… parameter's expression's name
FYI @cloud-fan |
AngersZhuuuu
changed the title
[SPARK-36093][SQL] RemoveRedundantAliases should not change Command's parameter's expression's name
[SPARK-36093][SQL][3.1] RemoveRedundantAliases should not change Command's parameter's expression's name
Jul 19, 2021
Kubernetes integration test starting |
Kubernetes integration test status failure |
cloud-fan
pushed a commit
that referenced
this pull request
Jul 19, 2021
…and's parameter's expression's name ### What changes were proposed in this pull request? RemoveRedundantAliases may change DataWritingCommand's parameter's attribute name. In the UT's case before RemoveRedundantAliases the partitionColumns is `CAL_DT`, and change by RemoveRedundantAliases and change to `cal_dt` then case the error case ### Why are the changes needed? Fix bug ### Does this PR introduce _any_ user-facing change? For below SQL case ``` sql("create table t1(cal_dt date) using parquet") sql("insert into t1 values (date'2021-06-27'),(date'2021-06-28'),(date'2021-06-29'),(date'2021-06-30')") sql("create view t1_v as select * from t1") sql("CREATE TABLE t2 USING PARQUET PARTITIONED BY (CAL_DT) AS SELECT 1 AS FLAG,CAL_DT FROM t1_v WHERE CAL_DT BETWEEN '2021-06-27' AND '2021-06-28'") sql("INSERT INTO t2 SELECT 2 AS FLAG,CAL_DT FROM t1_v WHERE CAL_DT BETWEEN '2021-06-29' AND '2021-06-30'") ``` Before this pr ``` sql("SELECT * FROM t2 WHERE CAL_DT BETWEEN '2021-06-29' AND '2021-06-30'").show +----+------+ |FLAG|CAL_DT| +----+------+ +----+------+ sql("SELECT * FROM t2 ").show +----+----------+ |FLAG| CAL_DT| +----+----------+ | 1|2021-06-27| | 1|2021-06-28| +----+----------+ ``` After this pr ``` sql("SELECT * FROM t2 WHERE CAL_DT BETWEEN '2021-06-29' AND '2021-06-30'").show +----+------+ |FLAG|CAL_DT| +----+------+ | 2|2021-06-29| | 2|2021-06-30| +----+------+ sql("SELECT * FROM t2 ").show +----+----------+ |FLAG| CAL_DT| +----+----------+ | 1|2021-06-27| | 1|2021-06-28| | 2|2021-06-29| | 2|2021-06-30| +----+----------+ ``` ### How was this patch tested? Added UT Closes #33417 from AngersZhuuuu/SPARK-36093-3.1. Authored-by: Angerszhuuuu <angers.zhu@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
merged to 3.1, thanks! |
Test build #141252 has finished for PR 33417 at commit
|
flyrain
pushed a commit
to flyrain/spark
that referenced
this pull request
Sep 21, 2021
…and's parameter's expression's name ### What changes were proposed in this pull request? RemoveRedundantAliases may change DataWritingCommand's parameter's attribute name. In the UT's case before RemoveRedundantAliases the partitionColumns is `CAL_DT`, and change by RemoveRedundantAliases and change to `cal_dt` then case the error case ### Why are the changes needed? Fix bug ### Does this PR introduce _any_ user-facing change? For below SQL case ``` sql("create table t1(cal_dt date) using parquet") sql("insert into t1 values (date'2021-06-27'),(date'2021-06-28'),(date'2021-06-29'),(date'2021-06-30')") sql("create view t1_v as select * from t1") sql("CREATE TABLE t2 USING PARQUET PARTITIONED BY (CAL_DT) AS SELECT 1 AS FLAG,CAL_DT FROM t1_v WHERE CAL_DT BETWEEN '2021-06-27' AND '2021-06-28'") sql("INSERT INTO t2 SELECT 2 AS FLAG,CAL_DT FROM t1_v WHERE CAL_DT BETWEEN '2021-06-29' AND '2021-06-30'") ``` Before this pr ``` sql("SELECT * FROM t2 WHERE CAL_DT BETWEEN '2021-06-29' AND '2021-06-30'").show +----+------+ |FLAG|CAL_DT| +----+------+ +----+------+ sql("SELECT * FROM t2 ").show +----+----------+ |FLAG| CAL_DT| +----+----------+ | 1|2021-06-27| | 1|2021-06-28| +----+----------+ ``` After this pr ``` sql("SELECT * FROM t2 WHERE CAL_DT BETWEEN '2021-06-29' AND '2021-06-30'").show +----+------+ |FLAG|CAL_DT| +----+------+ | 2|2021-06-29| | 2|2021-06-30| +----+------+ sql("SELECT * FROM t2 ").show +----+----------+ |FLAG| CAL_DT| +----+----------+ | 1|2021-06-27| | 1|2021-06-28| | 2|2021-06-29| | 2|2021-06-30| +----+----------+ ``` ### How was this patch tested? Added UT Closes apache#33417 from AngersZhuuuu/SPARK-36093-3.1. Authored-by: Angerszhuuuu <angers.zhu@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
fishcus
pushed a commit
to fishcus/spark
that referenced
this pull request
Jan 12, 2022
…and's parameter's expression's name ### What changes were proposed in this pull request? RemoveRedundantAliases may change DataWritingCommand's parameter's attribute name. In the UT's case before RemoveRedundantAliases the partitionColumns is `CAL_DT`, and change by RemoveRedundantAliases and change to `cal_dt` then case the error case ### Why are the changes needed? Fix bug ### Does this PR introduce _any_ user-facing change? For below SQL case ``` sql("create table t1(cal_dt date) using parquet") sql("insert into t1 values (date'2021-06-27'),(date'2021-06-28'),(date'2021-06-29'),(date'2021-06-30')") sql("create view t1_v as select * from t1") sql("CREATE TABLE t2 USING PARQUET PARTITIONED BY (CAL_DT) AS SELECT 1 AS FLAG,CAL_DT FROM t1_v WHERE CAL_DT BETWEEN '2021-06-27' AND '2021-06-28'") sql("INSERT INTO t2 SELECT 2 AS FLAG,CAL_DT FROM t1_v WHERE CAL_DT BETWEEN '2021-06-29' AND '2021-06-30'") ``` Before this pr ``` sql("SELECT * FROM t2 WHERE CAL_DT BETWEEN '2021-06-29' AND '2021-06-30'").show +----+------+ |FLAG|CAL_DT| +----+------+ +----+------+ sql("SELECT * FROM t2 ").show +----+----------+ |FLAG| CAL_DT| +----+----------+ | 1|2021-06-27| | 1|2021-06-28| +----+----------+ ``` After this pr ``` sql("SELECT * FROM t2 WHERE CAL_DT BETWEEN '2021-06-29' AND '2021-06-30'").show +----+------+ |FLAG|CAL_DT| +----+------+ | 2|2021-06-29| | 2|2021-06-30| +----+------+ sql("SELECT * FROM t2 ").show +----+----------+ |FLAG| CAL_DT| +----+----------+ | 1|2021-06-27| | 1|2021-06-28| | 2|2021-06-29| | 2|2021-06-30| +----+----------+ ``` ### How was this patch tested? Added UT Closes apache#33417 from AngersZhuuuu/SPARK-36093-3.1. Authored-by: Angerszhuuuu <angers.zhu@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
RemoveRedundantAliases may change DataWritingCommand's parameter's attribute name.
In the UT's case before RemoveRedundantAliases the partitionColumns is
CAL_DT
, and change by RemoveRedundantAliases and change tocal_dt
then case the error caseWhy are the changes needed?
Fix bug
Does this PR introduce any user-facing change?
For below SQL case
Before this pr
After this pr
How was this patch tested?
Added UT