[SPARK-36360][Spark Streaming] Remove appName from StreamingSource sourceName #33592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrclneumann
changed the title
mrclneumann
changed the title
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
MetricsSystemtakes care of proper naming of all metrics. By default, the root namespace is the value ofspark.app.id. A custom namespace can be specified for metrics reporting usingspark.metrics.namespaceconfiguration property.A
StreamingSourcegets registered in theMetricsSystem, however, it additionally includes theappNamein itssourceName. This makes it impossible to configure a common namespace excluding theappName.This pull request proposes to exclude the appName from the sourceName in StreamingSource following the example of the other sources, e.g.
ExecutorMetricsSource.Why are the changes needed?
Homogeneous naming scheme across all metrics.
Does this PR introduce any user-facing change?
The proposed change conforms to the documentation. See here.
How was this patch tested?
No tests added.