[SPARK-36404][SQL] Support ORC nested column vectorized reader for data source v2 #33626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c21
commented
Aug 3, 2021
| withSQLConf(SQLConf.ORC_VECTORIZED_READER_NESTED_COLUMN_ENABLED.key -> "true") { | ||
| val readDf = spark.read.orc(path) | ||
| val vectorizationEnabled = readDf.queryExecution.executedPlan.find { | ||
| case scan @ (_: FileSourceScanExec | _: BatchScanExec) => scan.supportsColumnar |
There was a problem hiding this comment.
Added BatchScanExec here for DS v2 compared to the original test in OrcSourceSuite.scala. Moved the query as we can test DS v1 and v2 here via OrcV1QuerySuite and OrcV2QuerySuite defined below.
|
Kubernetes integration test starting |
HyukjinKwon
approved these changes
Aug 4, 2021
|
Kubernetes integration test status success |
dongjoon-hyun
approved these changes
Aug 4, 2021
There was a problem hiding this comment.
+1, LGTM. Thank you, @c21 and @HyukjinKwon .
Merged to master
|
Thank you @HyukjinKwon and @dongjoon-hyun for review! |
|
Test build #142008 has finished for PR 33626 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We added support of nested columns in ORC vectorized reader for data source v1. Data source v2 and v1 both use same underlying implementation for vectorized reader (OrcColumnVector), so we can support data source v2 as well.
Why are the changes needed?
Improve query performance for ORC data source v2 when reading nested columns.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added test in
OrcQuerySuite.scala.