Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-35811][PYTHON][FOLLOWUP] Deprecate DataFrame.to_spark_io #33631

Closed
wants to merge 1 commit into from
Closed

[SPARK-35811][PYTHON][FOLLOWUP] Deprecate DataFrame.to_spark_io #33631

wants to merge 1 commit into from

Conversation

itholic
Copy link
Contributor

@itholic itholic commented Aug 4, 2021

What changes were proposed in this pull request?

This PR is followup for #32964, to improve the warning message.

Why are the changes needed?

To improve the warning message.

Does this PR introduce any user-facing change?

The warning is changed from "Deprecated in 3.2, Use spark.to_spark_io instead." to "Deprecated in 3.2, Use DataFrame.spark.to_spark_io instead."

How was this patch tested?

Manually run dev/lint-python

@itholic
Copy link
Contributor Author

itholic commented Aug 4, 2021

cc @cloud-fan @HyukjinKwon

@SparkQA
Copy link

SparkQA commented Aug 4, 2021

Test build #142022 has finished for PR 33631 at commit be4202e.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Aug 4, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46533/

@SparkQA
Copy link

SparkQA commented Aug 4, 2021

Test build #142023 has finished for PR 33631 at commit be4202e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 4, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46534/

@HyukjinKwon
Copy link
Member

Merged to master and branch-3.2.

HyukjinKwon pushed a commit that referenced this pull request Aug 4, 2021
### What changes were proposed in this pull request?

This PR is followup for #32964, to improve the warning message.

### Why are the changes needed?

To improve the warning message.

### Does this PR introduce _any_ user-facing change?

The warning is changed from "Deprecated in 3.2, Use `spark.to_spark_io` instead." to "Deprecated in 3.2, Use `DataFrame.spark.to_spark_io` instead."

### How was this patch tested?

Manually run `dev/lint-python`

Closes #33631 from itholic/SPARK-35811-followup.

Authored-by: itholic <haejoon.lee@databricks.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit 3d72c20)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
@SparkQA
Copy link

SparkQA commented Aug 4, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46534/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants