Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-36360][Streaming] Delete appName from StreamingSource sourceName #33632

Closed
wants to merge 2 commits into from
Closed

[SPARK-36360][Streaming] Delete appName from StreamingSource sourceName #33632

wants to merge 2 commits into from

Conversation

mrclneumann
Copy link

@mrclneumann mrclneumann commented Aug 4, 2021

What changes were proposed in this pull request?

This pull request proposes to exclude the appName from the sourceName in StreamingSource following the example of the other sources, e.g. ExecutorMetricsSource.

Why are the changes needed?

The StreamingSource includes the appName in its sourceName. However, the appName should not be handled by the StreamingSource. It is already handled by the MetricsSystem. See all other MetricSources, e.g. ExecutorMetricsSource.

Why is this important? See this part from the documentation:

Often times, users want to be able to track the metrics across apps for driver and executors, which is hard to do with application ID (i.e. spark.app.id) since it changes with every invocation of the app. For such use cases, a custom namespace can be specified for metrics reporting using spark.metrics.namespace configuration property. If, say, users wanted to set the metrics namespace to the name of the application, they can set the spark.metrics.namespace property to a value like ${spark.app.name}. This value is then expanded appropriately by Spark and is used as the root namespace of the metrics system.

This is only possible if the MetricsSystem handles the namespace which it does. But the StreamingSource additionally adds the appName in its sourceName, thus there is no way to configure a namespace that does not include the appName.

Does this PR introduce any user-facing change?

The proposed change conforms to the documentation. See here.

How was this patch tested?

No tests added.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@mrclneumann mrclneumann changed the title [SPARK-36360][Streaming] Remove appName from StreamingSource sourceName [SPARK-36360][Streaming] Delete appName from StreamingSource sourceName Aug 11, 2021
@github-actions
Copy link

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Nov 20, 2021
@github-actions github-actions bot closed this Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants