Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARK-4532: Fix bug in detection of Hive in Spark 1.2 #3398

Closed
wants to merge 1 commit into from

Conversation

pwendell
Copy link
Contributor

Because the Hive profile is no longer defined in the root pom,
we need to check specifically in the sql/hive pom when we
perform the check in make-distribtion.sh.

Because the Hive profile is no longer defined in the root pom,
we need to check specifically in the sql/hive pom when we
perform the check in make-distribtion.sh.
@pwendell pwendell changed the title Fix bug in detection of Hive in Spark 1.2 SPARK-4532: Fix bug in detection of Hive in Spark 1.2 Nov 21, 2014
@SparkQA
Copy link

SparkQA commented Nov 21, 2014

Test build #23710 has started for PR 3398 at commit 8a58279.

  • This patch merges cleanly.

@liancheng
Copy link
Contributor

LGTM

@pwendell
Copy link
Contributor Author

Thanks @liancheng

@zzcclp
Copy link
Contributor

zzcclp commented Nov 21, 2014

@pwendell, I use command as follows:
mvn help:evaluate -Dexpression=project.activeProfiles -pl sql/hive -Phadoop-2.3 -Phive-0.13.1 -Phive-thriftserver -Pyarn -Dyarn.version=2.3.0-cdh5.1.2 -Dhadoop.version=2.3.0-cdh5.1.2 2>/dev/null | grep -v "INFO" | fgrep --count "hive"

or

mvn help:evaluate -Dexpression=project.activeProfiles -pl sql/hive -Phadoop-2.3 -Phive-0.13.1 -Phive-thriftserver -Pyarn -Dyarn.version=2.3.0-cdh5.1.2 -Dhadoop.version=2.3.0-cdh5.1.2 2>/dev/null | grep -v "INFO" | fgrep --count "hive-0.13.1"

it still return 0, if use command as follows:
mvn help:evaluate -Dexpression=project.activeProfiles -Phadoop-2.3 -Phive-0.13.1 -Phive-thriftserver -Pyarn -Dyarn.version=2.3.0-cdh5.1.2 -Dhadoop.version=2.3.0-cdh5.1.2 2>/dev/null | grep -v "INFO" | fgrep --count "hive-0.13.1"
it return 1, is something wrong with it?

@liancheng
Copy link
Contributor

@zzcclp You also need to add -Phive. -Phive implies -Phive-0.13.1, but not vice versa.

@zzcclp
Copy link
Contributor

zzcclp commented Nov 21, 2014

@liancheng, thanks

@SparkQA
Copy link

SparkQA commented Nov 21, 2014

Test build #23710 has finished for PR 3398 at commit 8a58279.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23710/
Test PASSed.

@asfgit asfgit closed this in a81918c Nov 24, 2014
asfgit pushed a commit that referenced this pull request Nov 24, 2014
Because the Hive profile is no longer defined in the root pom,
we need to check specifically in the sql/hive pom when we
perform the check in make-distribtion.sh.

Author: Patrick Wendell <pwendell@gmail.com>

Closes #3398 from pwendell/make-distribution and squashes the following commits:

8a58279 [Patrick Wendell] Fix bug in detection of Hive in Spark 1.2

(cherry picked from commit a81918c)
Signed-off-by: Patrick Wendell <pwendell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants