[SPARK-36712][BUILD][FOLLOWUP] Improve the regex to avoid breaking pom.xml #33996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @lrytz |
|
Oh was it not working to go back to 2.12? ah OK in any event, good catch. |
|
Yes, this PR restores the previous behavior. It was no-op when we use the same scala version before SPARK-36712. Although we switched to Scala 2.13 by default, SPARK-36712's regex will fail |
viirya
approved these changes
Sep 14, 2021
sunchao
approved these changes
Sep 14, 2021
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
dongjoon-hyun
added a commit
that referenced
this pull request
Sep 14, 2021
…m.xml ### What changes were proposed in this pull request? This PR aims to fix the regex to avoid breaking `pom.xml`. ### Why are the changes needed? **BEFORE** ``` $ dev/change-scala-version.sh 2.12 $ git diff | head -n10 diff --git a/core/pom.xml b/core/pom.xml index dbde22f2bf..6ed368353b 100644 --- a/core/pom.xml +++ b/core/pom.xml -35,7 +35,7 </properties> <dependencies> - <!--<!-- ``` **AFTER** Since the default Scala version is `2.12`, the following `no-op` is the correct behavior which is consistent with the previous behavior. ``` $ dev/change-scala-version.sh 2.12 $ git diff ``` ### Does this PR introduce _any_ user-facing change? No. This is a dev only change. ### How was this patch tested? Manually. Closes #33996 from dongjoon-hyun/SPARK-36712. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit d730ef2) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Test build #143277 has finished for PR 33996 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix the regex to avoid breaking
pom.xml.Why are the changes needed?
BEFORE
AFTER
Since the default Scala version is
2.12, the followingno-opis the correct behavior which is consistent with the previous behavior.Does this PR introduce any user-facing change?
No. This is a dev only change.
How was this patch tested?
Manually.