Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-4377] Fixed serialization issue by switching to akka provided serializer. #3402

Closed

Conversation

ScrapCodes
Copy link
Member

... - there is no way around this for deserializing actorRef(s).

…serializer - there is no way around this for deserializing actorRef(s).
@SparkQA
Copy link

SparkQA commented Nov 21, 2014

Test build #23721 has started for PR 3402 at commit 29880da.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 21, 2014

Test build #23721 has finished for PR 3402 at commit 29880da.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • abstract class StandaloneRecoveryModeFactory(conf: SparkConf, serializer: Serialization)

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23721/
Test FAILed.

@ScrapCodes
Copy link
Member Author

@JoshRosen Please take a look and see if this fix works for us.

@SparkQA
Copy link

SparkQA commented Nov 21, 2014

Test build #23722 has started for PR 3402 at commit 9b35c6e.

  • This patch merges cleanly.

@ScrapCodes
Copy link
Member Author

Even after this fix someone can run into same errors if he suppose builds spark with scala 2.10 and runs master first and then try to recover it with spark built with scala 2.11. This is definitely not our case. But just mentioning it since I observed it while testing.

@SparkQA
Copy link

SparkQA commented Nov 21, 2014

Test build #23723 has started for PR 3402 at commit 77233fd.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 21, 2014

Test build #23722 has finished for PR 3402 at commit 9b35c6e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • abstract class StandaloneRecoveryModeFactory(conf: SparkConf, serializer: Serialization)

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23722/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Nov 21, 2014

Test build #23723 has finished for PR 3402 at commit 77233fd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • abstract class StandaloneRecoveryModeFactory(conf: SparkConf, serializer: Serialization)

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23723/
Test PASSed.

@JoshRosen
Copy link
Contributor

I ran my ZKFaultToleranceSuite and this now passes all tests! Haven't reviewed the actual fix yet, but I can confirm that it fixes the exception reported in the JIRA.

@pwendell
Copy link
Contributor

Okay I reviewed this and it LGTM. Fortunately, these changes are isolated to those using recoverability mechanisms.

@aarondav
Copy link
Contributor

Actually this effectively reverts the changes made to the serializer in #771, which was only merged for 1.2, so this should mean that such people are no more affected than they already were by the upgrade.

@pwendell
Copy link
Contributor

@aarondav did you mean "only merged for 1.3"?

@asfgit asfgit closed this in 9b2a3c6 Nov 24, 2014
@aarondav
Copy link
Contributor

Oops, that's probably corrector, sorry!

tianyi pushed a commit to asiainfo/spark that referenced this pull request Dec 4, 2014
…serializer.

... - there is no way around this for deserializing actorRef(s).

Author: Prashant Sharma <prashant.s@imaginea.com>

Closes apache#3402 from ScrapCodes/SPARK-4377/troubleDeserializing and squashes the following commits:

77233fd [Prashant Sharma] Style fixes
9b35c6e [Prashant Sharma] Scalastyle fixes
29880da [Prashant Sharma] [SPARK-4377] Fixed serialization issue by switching to akka provided serializer - there is no way around this for deserializing actorRef(s).
@ScrapCodes ScrapCodes deleted the SPARK-4377/troubleDeserializing branch June 3, 2015 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants