-
Notifications
You must be signed in to change notification settings - Fork 28k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-4377] Fixed serialization issue by switching to akka provided serializer. #3402
[SPARK-4377] Fixed serialization issue by switching to akka provided serializer. #3402
Conversation
…serializer - there is no way around this for deserializing actorRef(s).
Test build #23721 has started for PR 3402 at commit
|
Test build #23721 has finished for PR 3402 at commit
|
Test FAILed. |
@JoshRosen Please take a look and see if this fix works for us. |
Test build #23722 has started for PR 3402 at commit
|
Even after this fix someone can run into same errors if he suppose builds spark with scala 2.10 and runs master first and then try to recover it with spark built with scala 2.11. This is definitely not our case. But just mentioning it since I observed it while testing. |
Test build #23723 has started for PR 3402 at commit
|
Test build #23722 has finished for PR 3402 at commit
|
Test PASSed. |
Test build #23723 has finished for PR 3402 at commit
|
Test PASSed. |
I ran my ZKFaultToleranceSuite and this now passes all tests! Haven't reviewed the actual fix yet, but I can confirm that it fixes the exception reported in the JIRA. |
Okay I reviewed this and it LGTM. Fortunately, these changes are isolated to those using recoverability mechanisms. |
Actually this effectively reverts the changes made to the serializer in #771, which was only merged for 1.2, so this should mean that such people are no more affected than they already were by the upgrade. |
@aarondav did you mean "only merged for 1.3"? |
Oops, that's probably corrector, sorry! |
…serializer. ... - there is no way around this for deserializing actorRef(s). Author: Prashant Sharma <prashant.s@imaginea.com> Closes apache#3402 from ScrapCodes/SPARK-4377/troubleDeserializing and squashes the following commits: 77233fd [Prashant Sharma] Style fixes 9b35c6e [Prashant Sharma] Scalastyle fixes 29880da [Prashant Sharma] [SPARK-4377] Fixed serialization issue by switching to akka provided serializer - there is no way around this for deserializing actorRef(s).
... - there is no way around this for deserializing actorRef(s).