Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-36848][SQL][FOLLOWUP] Simplify SHOW CURRENT NAMESPACE command #34128

Closed
wants to merge 1 commit into from

Conversation

cloud-fan
Copy link
Contributor

What changes were proposed in this pull request?

This is a followup of #34104

SHOW CURRENT NAMESPACE is a very simple command that does not involve v2 catalog API, does not need analysis, does not have children. We can simply use RunnableCommand to save defining the physical plan.

Why are the changes needed?

code simplification

Does this PR introduce any user-facing change?

no

How was this patch tested?

existing tests

@github-actions github-actions bot added the SQL label Sep 28, 2021
@cloud-fan
Copy link
Contributor Author

@huaxingao

@SparkQA
Copy link

SparkQA commented Sep 28, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48192/

@SparkQA
Copy link

SparkQA commented Sep 28, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48192/

@viirya
Copy link
Member

viirya commented Sep 28, 2021

Thanks! Pending CI.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@dongjoon-hyun
Copy link
Member

Merged to master for Apache Spark 3.3.

@SparkQA
Copy link

SparkQA commented Sep 28, 2021

Test build #143678 has finished for PR 34128 at commit 9222d6e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • case class ShowCurrentNamespaceCommand() extends LeafRunnableCommand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants