Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-36977][DOCS][PYTHON] Drop references to Python 3.6 support in docs and python/docs #34242

Closed
wants to merge 1 commit into from

Conversation

zero323
Copy link
Member

@zero323 zero323 commented Oct 11, 2021

What changes were proposed in this pull request?

Remove or adjust references to Python 3.6 in docs and python/docs.

Why are the changes needed?

To reflect removal of support in Spark 3.3 (SPARK-36145).

Does this PR introduce any user-facing change?

Updated documentation only.

How was this patch tested?

Manual rendering of individual docs.

Spark {{site.SPARK_VERSION}} works with Python 3.6+. It can use the standard CPython interpreter,
so C libraries like NumPy can be used. It also works with PyPy 2.3+.
Spark {{site.SPARK_VERSION}} works with Python 3.7+. It can use the standard CPython interpreter,
so C libraries like NumPy can be used. It also works with PyPy 7.3.6+.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Updated PyPy version (it seems like it hasn't been updated in ages).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think its fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In practice, we could probably target a bit lower (seems like 7.3.4 is the first version with stable 3.7 support).

@SparkQA
Copy link

SparkQA commented Oct 11, 2021

Test build #144087 has finished for PR 34242 at commit 0f26b14.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 11, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48565/

@SparkQA
Copy link

SparkQA commented Oct 11, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48565/

@HyukjinKwon
Copy link
Member

We'll have to fix setup.py for Python version, and remove things like https://github.com/apache/spark/blob/master/python/pyspark/context.py#L233-L239 but they can be done separately.

Merged to master.

@zero323
Copy link
Member Author

zero323 commented Oct 12, 2021

Thanks @HyukjinKwon

We'll have to fix setup.py for Python version, and remove things like https://github.com/apache/spark/blob/master/python/pyspark/context.py#L233-L239 but they can be done separately.

Yeah, I wanted to avoid code changes here. There are things you mentioned, but also some pieces of code, that target earlier Python versions, which could be safely removed.

@zero323 zero323 deleted the SPARK-36977 branch October 12, 2021 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants