Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-37000][PYTHON] Add type hints to python/pyspark/sql/util.py #34278

Closed
wants to merge 2 commits into from

Conversation

ueshin
Copy link
Member

@ueshin ueshin commented Oct 13, 2021

What changes were proposed in this pull request?

Adds type hints to python/pyspark/sql/util.py.

Why are the changes needed?

Currently type hints for the file python/pyspark/sql/util.py are missing.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manually ran mypy.

@SparkQA
Copy link

SparkQA commented Oct 13, 2021

Test build #144215 has finished for PR 34278 at commit a4afa75.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@ueshin
Copy link
Member Author

ueshin commented Oct 13, 2021

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Oct 14, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48694/

@SparkQA
Copy link

SparkQA commented Oct 14, 2021

Test build #144218 has finished for PR 34278 at commit a4afa75.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 14, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48697/

@SparkQA
Copy link

SparkQA commented Oct 14, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48694/

@SparkQA
Copy link

SparkQA commented Oct 14, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48697/

@SparkQA
Copy link

SparkQA commented Oct 14, 2021

Test build #144269 has finished for PR 34278 at commit 61317e6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
  • class SparkUpgradeException(CapturedException):
  • public class ExpressionImplUtils
  • case class AesEncrypt(input: Expression, key: Expression, child: Expression)
  • case class AesDecrypt(input: Expression, key: Expression, child: Expression)
  • case class ShowCatalogsCommand(pattern: Option[String]) extends LeafRunnableCommand

@SparkQA
Copy link

SparkQA commented Oct 14, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48748/

@SparkQA
Copy link

SparkQA commented Oct 14, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48748/

@ueshin
Copy link
Member Author

ueshin commented Oct 14, 2021

Thanks! merging to master.

@ueshin ueshin closed this in 2267d7f Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants