[SPARK-37026][ML][BUILD] Ensure the element type of ResolvedRFormula.terms
is scala.Seq for Scala 2.13
#34301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes the issue that
scala.Seq[scala.collection.mutable.ArraySeq$ofRef]
will be passed toResolvedRFormula.terms
though it expectsscala.Seq[scala.Seq[String]]
with Scala 2.13.As of Scala 2.13,
scala.Seq
isscala.collection.immutable.Seq
, so this issue happens.Why are the changes needed?
Bug fix.
Due to this issue,
ResolvedRFormula.toString
throwsClassCastException
.Does this PR introduce any user-facing change?
No.
How was this patch tested?
New test is added and
build/sbt -Pscala-2.13 "testOnly org.apache.spark.ml.feature.RFormulaSuite"
passes.CIs should ensure that this change works with Scala 2.12 too.